[HOLD for payment 2023-07-26] [$1000] Change language also trigger submit Sign in validation form when magic codes are fullfilled

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Go to Sign in page
2. Enter any Expensify account
3. Fill-in incorrect magic codes
4. Verify that the form show "Incorrect magic code"
5. Scroll to bottom, change to another language

Expected Result:

The Sign in validation form should not be auto submitted

Actual Result:

The Sign in validation form is auto submitted

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.35-5
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Desktop.2023.06.30.-.20.27.50.06.mp4

Screen.Recording.2023-06-30.at.17.07.48.mov

Expensify/Expensify Issue URL:
Issue reported by: @hoangzinh

Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1688119742990839

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01a3cba7e2b4d05772
• Upwork Job ID: 1678889176475852800
• Last Price Increase: 2023-07-11

[melvin-bot]

Triggered auto assignment to @michaelhaxhiu (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[kavimuru]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Change language also trigger submit Sign in validation form when magic codes are fullfilled

What is the root cause of that problem?

• In MagicCodeInput component, we have a useEffect that will be triggered when props.onFulfill be changed
  

  App/src/components/MagicCodeInput.js

  Lines 147 to 152 in 3404111

  	useEffect(() => {
  	validateAndSubmit();
  	// We have not added the editIndex as the dependency because we don't want to run this logic after focusing on an input to edit it after the user has completed the code.
  	// eslint-disable-next-line react-hooks/exhaustive-deps
  	}, [props.value, props.shouldSubmitOnComplete, props.onFulfill]);

• When we make the callback onFulfill to pass as a props to MagicCodeInput component in the BaseValidateCodeForm component, this callback will be updated whenever the props.preferredLocale is changed
  

  App/src/pages/signin/ValidateCodeForm/BaseValidateCodeForm.js

  Line 220 in 3404111

  }, [props.account.requiresTwoFactorAuth, props.credentials, props.preferredLocale, twoFactorAuthCode, validateCode]);

  
  => That means when the preferredLocale is changed => It changes how onFulfill callback should be => also trigger this MagicCodeInput useEffect to call validateAndSubmit

What changes do you think we should make in order to solve the problem?

I think the purpose of this this MagicCodeInput useEffect is auto validate form if the magic codes are fulfilled. So we don't really need to trigger it when props.onFulfill is updated => I suggest we should remove props.onFulfill from dependency list here

[hoangzinh]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Change language also trigger submit Sign in validation form when magic codes are fullfilled

What is the root cause of that problem?

• In MagicCodeInput component, we have a useEffect that will be triggered when props.onFulfill be changed
  

  App/src/components/MagicCodeInput.js

  Lines 147 to 152 in 3404111

  	useEffect(() => {
  	validateAndSubmit();
  	// We have not added the editIndex as the dependency because we don't want to run this logic after focusing on an input to edit it after the user has completed the code.
  	// eslint-disable-next-line react-hooks/exhaustive-deps
  	}, [props.value, props.shouldSubmitOnComplete, props.onFulfill]);

• When we make the callback onFulfill to pass as a props to MagicCodeInput component in the BaseValidateCodeForm component, this callback will be updated whenever the props.preferredLocale is changed
  

  App/src/pages/signin/ValidateCodeForm/BaseValidateCodeForm.js

  Line 220 in 3404111

  }, [props.account.requiresTwoFactorAuth, props.credentials, props.preferredLocale, twoFactorAuthCode, validateCode]);

  
  => That means when the preferredLocale is changed => It changes how onFulfill callback should be => also trigger this MagicCodeInput useEffect to call validateAndSubmit

What changes do you think we should make in order to solve the problem?

I think the purpose of this this MagicCodeInput useEffect is auto validate form if the magic codes are fulfilled. So we don't really need to trigger it when props.onFulfill is updated => I suggest we should remove props.onFulfill from dependency list here

[melvin-bot]

@michaelhaxhiu Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[melvin-bot]

@michaelhaxhiu Eep! 4 days overdue now. Issues have feelings too...

[melvin-bot]

@michaelhaxhiu 8 days overdue is a lot. Should this be a Weekly issue? If so, feel free to change it!

[michaelhaxhiu]

Sorry for the delay folks.