[$1000] Web - 'Notify me' option doesn't update on Unavailable workspace

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Go to staging dot on web chrome and login with User A
2. Create a new workspace and invite User B and click on the announce channel
3. Login with User B on another web chrome and go to the announce channel
4. Important step- Now close the browser for User B
5. From User A, remove the User B from the workspace (members > remove User B)
6. On user B, open the browser again so that User B is able to see 'Unavailable Workspace' on announce.
7. From user B, go to 'Unavailable workspace' header and click on 'Notify me about messages' and try to select different options from there.
8. Notice that even if you select other options, it switches back to the default option - Daily

Expected Result:

If settings can't be changed for unavailable workspace, we can either not show settings OR if we decide to show settings, then it should be updated if the user selects different options

Actual Result:

'Notify me' option doesn't update on the Unavailable workspace

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.33-4
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Recording.3305.mp4

green-2023-06-28_11.41.43.mp4

Expensify/Expensify Issue URL:
Issue reported by: @priya-zha
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1687932409885299

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01c0766bb586cb325f
• Upwork Job ID: 1677141743908093952
• Last Price Increase: 2023-07-07

[melvin-bot]

Triggered auto assignment to @adelekennedy (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[StevenKKC]

Proposal

Please re-state the problem that we are trying to solve in this issue.

'Notify me' option doesn't update on Unavailable workspace.

What is the root cause of that problem?

Once a user is removed from a workspace, he cannot update workspace notification settings, and the server will respond "Report no longer exists".
App does not check to see if the workspace is available, and the UI does not reflect the server's response.

What changes do you think we should make in order to solve the problem?

The workspace details page can be blocked from being accessed by the removed user.
We can add a utility function ReportUtils.isAvailableWorkspace that checks if a workspace is available.

And in this line, we can check whether workspace is available using a utility function.

What alternative solutions did you explore? (Optional)

None.

[hungvu193]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Web - 'Notify me' option doesn't update on Unavailable workspace

What is the root cause of that problem?

We still receive information from a room that we aren't member from backend. This because if user didn't open the app when they didn't receive pusher event to remove announce report from their end.

What changes do you think we should make in order to solve the problem?

In this case, we can update our canSeeDefaultRoom in here because it's used to filter our report in SidebarLinks also the current report to display

 const policy = allPolicies[`${ONYXKEYS.COLLECTION.POLICY}${report.policyID}`];
  // place this below isDomainRoom
    if (isChatRoom(report) && !policy) {
        return false;
    }

What alternative solutions did you explore? (Optional)

N/A

[melvin-bot]

@adelekennedy Eep! 4 days overdue now. Issues have feelings too...

[melvin-bot]

@adelekennedy 6 days overdue. This is scarier than being forced to listen to Vogon poetry!

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01c0766bb586cb325f

[melvin-bot]

Current assignee @adelekennedy is eligible for the External assigner, not assigning anyone new.