[HOLD for payment 2023-08-10] [$1000] Chat - Account B will have a pencil saved when only the admin can write in the announcement room

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Issue foung when executing PR #21376

Action Performed:

1. Login with user A --> create new workspace--> invite user B
2. Open announce room of above workspace --> detail chat --> settting --> who can post --> choose All member
3. Login with user B on another device --> Open announce chat of above workspace --> Write something
4. On user A choose who can post --> admin only

Expected Result:

The pencil should disappear if only admin A can send messages

Actual Result:

When only the administrator can write in the message room, and user B has left a message in the compose box, the pencil does not disappear

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.34.1

Reproducible in staging?: Yes

Reproducible in production?: Yes

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Recording.2268.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01db389064c4161941
• Upwork Job ID: 1676726165094825984
2023-07-24
• Automatic offers:
• | | 0
• Nikhil-Vats | Contributor | 25719953

[melvin-bot]

Triggered auto assignment to @mallenexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[jeet-dhandha]

Proposal

Please re-state the problem that we are trying to solve in this issue.

• Problem is that hasDraftComment in OptionRowLHN remain's true even after the permission to write is given only to admins.

What is the root cause of that problem?

• The root cause of the problem is that on permission change the hasDraft key in report is not updated and remains true.

What changes do you think we should make in order to solve the problem?

• We can use the isAllowedToComment function to check if the user is allowed to comment or not and then render Draft icon accordingly. (This is similar to what we did with ReportActionCompose. )

const report = ReportUtils.getReport(props.reportID);
const isAllowedToComment = ReportUtils.isAllowedToComment(report);

App/src/components/LHNOptionsList/OptionRowLHN.js

Lines 246 to 253 in 19ca306

	{optionItem.hasDraftComment && (
	<View
	style={styles.ml2}
	accessibilityLabel={props.translate('sidebarScreen.draftedMessage')}
	>
	<Icon src={Expensicons.Pencil} />
	</View>
	)}

-  {optionItem.hasDraftComment && (
+  {optionItem.hasDraftComment && isAllowedToComment && (

What alternative solutions did you explore? (Optional)

• Other solution could be we handle changes in backend to set the hasDraft key to false when the permission is changed for a report.

[Nikhil-Vats]

Proposal

Please re-state the problem that we are trying to solve in this issue.

If a user has a draft message in a room and the room permission is changed to admin only then the draft indicator (pencil icon) is not removed.

What is the root cause of that problem?

We show the pencil icon (draft message indicator) without checking if room is archived, has errors or permissions -

App/src/components/LHNOptionsList/OptionRowLHN.js

Lines 246 to 253 in 53e4154

	{optionItem.hasDraftComment && (
	<View
	style={styles.ml2}
	accessibilityLabel={props.translate('sidebarScreen.draftedMessage')}
	>
	<Icon src={Expensicons.Pencil} />
	</View>
	)}

So if the room is archived, has any errors, or permission is changed to admin only then composer will be hidden but draft icon will show if user had a draft message before.

What changes do you think we should make in order to solve the problem?

We use the following function to hide the composer when room is archived, report has any errors or permissions are changed to admin only -

App/src/libs/ReportUtils.js

Lines 2319 to 2327 in 53e4154

	/**
	* Return true if the composer should be hidden
	* @param {Object} report
	* @param {Object} reportErrors
	* @returns {Boolean}
	*/
	function shouldHideComposer(report, reportErrors) {
	return isArchivedRoom(report) || !_.isEmpty(reportErrors) || !isAllowedToComment(report);
	}

We should use the same function to remove the draft icon dynamically in all 3 cases.

In the OptionRowLHN component, we have only reportID. To get report, reportErrors we can use the getReport function in ReportUtils and then we can get the reportErrors from the report object's errorFields key in the same way we are getting it for composer.

App/src/libs/ReportUtils.js

Lines 1134 to 1136 in 53e4154

	function getReport(reportID) {
	return lodashGet(allReports, `${ONYXKEYS.COLLECTION.REPORT}${reportID}`, {});
	}

const hideDraftIcon = ReportUtils.shouldHideComposer(report, reportErrors);
// ... rest of the code
{optionItem.hasDraftComment && !hideDraftIcon && (
    <View
        style={styles.ml2}
        accessibilityLabel={props.translate('sidebarScreen.draftedMessage')}
    >
        <Icon src={Expensicons.Pencil} />
    </View>
)}

We can also move the optionItem.hasDraftComment logic to hideDraftIcon variable and render the draft icon using -

{!hideDraftIcon && ...
...
}

Additionally, we can rename the shouldHideComposer to something more generic if needed.

What alternative solutions did you explore? (Optional)

NA

[mallenexpensify]

Interesting. Having troubles testing cuz, when I invite use B to the workspace, I don't see them as a member but User B has access to the workspace and announce room. Anyone know what might be going wrong?

User B vie

User A view

[melvin-bot]

@mallenexpensify Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[Nikhil-Vats]

@mallenexpensify I just tested what you said locally and it didn't happen for me. Would you mind trying again?

[jeet-dhandha]

@Nikhil-Vats - Still reproducible.

[Nikhil-Vats]

Yes @jeet-dhandha . The issue is still reproducible. I meant the other issue that @mallenexpensify was talking about was not reproducible for me.

[melvin-bot]

@mallenexpensify Huh... This is 4 days overdue. Who can take care of this?