[HOLD for payment 2023-07-24] [$1000] DEV: App crash when go to settings of public room

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Open App
2. Go to any public room (e.g. http://localhost:8080/r/8936976277251806)
3. Open settings of public room

Expected Result:

App should not crash

Actual Result:

App crash when go to settings

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number:
Reproducible in staging?: DEV
Reproducible in production?:
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

AppCrash.mov

Expensify/Expensify Issue URL:
Issue reported by: @PrashantMangukiya
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1687760658520999

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01507221e6e9e02915
• Upwork Job ID: 1676955027897794560
• Last Price Increase: 2023-07-06

[melvin-bot]

Triggered auto assignment to @johncschuster (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[kavimuru]

Proposal

Please re-state the problem that we are trying to solve in this issue.

DEV: App crash when go to settings of public room

What is the root cause of that problem?

We are translating visibility description via this code:

App/src/pages/settings/Report/ReportSettingsPage.js

Line 203 in 64b720c

<Text style={[styles.textLabelSupporting, styles.mt1]}>{this.props.translate(`newRoomPage.${this.props.report.visibility}Description`)}</Text>

Value for this.props.report.visibility comes as 'public_announce'. But we need only 'public' word. So this is the root cause of the problem.

What changes do you think we should make in order to solve the problem?

We have to remove value after _ as shown code below:

// <Text style={[styles.textLabelSupporting, styles.mt1]}>{this.props.translate(`newRoomPage.${this.props.report.visibility}Description`)}</Text> // *** OLD CODE ***
<Text style={[styles.textLabelSupporting, styles.mt1]}>{this.props.translate(`newRoomPage.${this.props.report.visibility.replace(/_.+/g, '')}Description`)}</Text> // *** UPDATED CODE ***

What alternative solutions did you explore? (Optional)

None

Result

https://github.com/Expensify/App/assets/7823358/1af23bfa-1641-4326-9e4a-de5f0722a6c2

[hungvu193]

Proposal

Please re-state the problem that we are trying to solve in this issue.

DEV: App crash when go to settings of public room

What is the root cause of that problem?

We're translating the room description here:

App/src/pages/settings/Report/ReportSettingsPage.js

Line 203 in 64b720c

<Text style={[styles.textLabelSupporting, styles.mt1]}>{this.props.translate(`newRoomPage.${this.props.report.visibility}Description`)}</Text>

For the room in this issue, the visibility props was public_announce so the translation key will be newRoomPage.public_announceDescription which didn't exist in our translation files, which caused the issue.

What changes do you think we should make in order to solve the problem?

Add the translation key for the missing key in our en.js es.js:

      newRoomPage: {
         public_announceDescription: 'Description for public announce room',
      }
      

What alternative solutions did you explore? (Optional)

N/A

[melvin-bot]

@johncschuster Huh... This is 4 days overdue. Who can take care of this?

[melvin-bot]

@johncschuster Still overdue 6 days?! Let's take care of this!

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01507221e6e9e02915