[HOLD for payment 2023-07-14] [$1000] Error message displayed when User flags a message with no permission in a group chat

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Login with userA account
2. Go to the “New room” section
3. Enter room name and select userA workspace
4. Select visibility to “Public”
5. Click on “Create room”
6. Send some messages in room chat
7. Go to the room detail
8. Share code > Copy URL to clipboard
9. Go back and click on Settings > Who can post
10. Select Admin only
11. Open other browser and login with userB account
12. Join the room by pasting URL
    13 Now click on “flag as offensive”
13. Click on any option

Expected Result:

Error message "Auth CreateReportAction returned an error" displayed when UserB flags a message without posting permission in a group chat

Actual Result:

The error message "Auth CreateReportAction returned an error" is displayed when UserB flags a message without having permission to post in the group chat

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.33-4
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

screen-recording-2023-06-24-at-82841-pm_IQp5roly.mp4

Recording.1119.mp4

Expensify/Expensify Issue URL:
Issue reported by: @ayazhussain79
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1687621449744259

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0129a94963f8137bb5
• Upwork Job ID: 1674063676186324992
• Last Price Increase: 2023-06-28

[melvin-bot]

Triggered auto assignment to @twisterdotcom (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[hungvu193]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Error message displayed when User flags a message with no permission in a group chat

What is the root cause of that problem?

We're allowing user to flag comment even they didn't have the permission in the room in here:

App/src/pages/home/report/ContextMenu/ContextMenuActions.js

Lines 322 to 328 in 52a1891

	shouldShow: (type, reportAction, isArchivedRoom, betas, menuTarget, isChronosReport, reportID) =>
	type === CONTEXT_MENU_TYPES.REPORT_ACTION &&
	ReportUtils.canFlagReportAction(reportAction, reportID) &&
	!isArchivedRoom &&
	!isChronosReport &&
	!ReportUtils.isConciergeChatReport(reportID) &&
	reportAction.actorEmail !== CONST.EMAIL.CONCIERGE,

But from our server, if users don't have permission, they also don't have permission to flag the comment, which caused the issue.

What changes do you think we should make in order to solve the problem?

We need to check if current user didn't have permission to comment, then we should hide the flag comment in our context menu.

        shouldShow: (type, reportAction, isArchivedRoom, betas, menuTarget, isChronosReport, reportID) =>
            type === CONTEXT_MENU_TYPES.REPORT_ACTION &&
            ReportUtils.canFlagReportAction(reportAction, reportID) &&
            !isArchivedRoom &&
            !isChronosReport &&
            !ReportUtils.isConciergeChatReport(reportID) &&
            reportAction.actorEmail !== CONST.EMAIL.CONCIERGE &&
            ReportUtils.isAllowedToComment(ReportUtils.getReport(reportID)),

We can also do the same with reply in thread menu options.

Incase a FlagCommentPage was already opened while the room setting was changed to "Admins only", we can add a FullPageNotFoundView inside FlagCommentPage and check if user is not allowed to comment then show the NotFound view, or dismiss the modal by adding an useEffect to check.

What alternative solutions did you explore? (Optional)

N/A

[twisterdotcom]

I am OOO! Adding another BZ member for the week.

[melvin-bot]

Triggered auto assignment to @anmurali (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.