[HOLD for payment 2023-08-01] [$1000] Users who are not assigned can update the assignor for the task and update the status of the task

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Login 2 account A and B on 2 devices
2. A create a group include B and C
3. A create a task but not assign anyone
4. B go to detail a task, observed that B cannot update status task
5. B click avatar where the person is assigned
6. B assign myself
7. B click "mark as done"

Expected Result:

B can't assign himself and update the task

Actual Result:

B can assign himself and update the task

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.33-2
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Screen.Recording.2023-06-24.at.20.29.58.mov

Recording.1117.mp4

Expensify/Expensify Issue URL:
Issue reported by: @namhihi237
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1687614685996199

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~018d124d13032a7005
• Upwork Job ID: 1676990326156591104
• Last Price Increase: 2023-07-06

[melvin-bot]

Triggered auto assignment to @kevinksullivan (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[namhihi237]

Proposal

Please re-state the problem that we are trying to solve in this issue.

B can't assign himself and update the task

What is the root cause of that problem?

In TaskHeader we did not check who can open the modal change assign

App/src/components/TaskHeader.js

Line 54 in c122266

const isOpen = props.report.stateNum === CONST.REPORT.STATE_NUM.OPEN && props.report.statusNum === CONST.REPORT.STATUS.OPEN;

App/src/components/TaskHeader.js

Lines 66 to 69 in c122266

	<PressableWithFeedback
	onPress={() => Navigation.navigate(ROUTES.getTaskReportAssigneeRoute(props.report.reportID))}
	disabled={!isOpen}
	accessibilityRole="button"

What changes do you think we should make in order to solve the problem?

We need to check if the current user is ownerAccountID or not, If not we will disable

const isOwner = props.session.accountID === props.report.ownerAccountID;
const isOpen = props.report.stateNum === CONST.REPORT.STATE_NUM.OPEN && props.report.statusNum === CONST.REPORT.STATUS.OPEN && isOwner;

Result:

Screen.Recording.2023-06-28.at.01.10.47.mov

What alternative solutions did you explore? (Optional)

N/A

[kevinksullivan]

checking on expected behavior in slack before moving forward

https://expensify.slack.com/archives/C049HHMV9SM/p1687989265525919?thread_ts=1687614685.996199&cid=C049HHMV9SM

[melvin-bot]

@kevinksullivan Huh... This is 4 days overdue. Who can take care of this?

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~018d124d13032a7005

[melvin-bot]

Triggered auto assignment to @puneetlath (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.