[HOLD for payment 2023-07-24] [$1000] Payments - App allows to add paypal account using deep link even if paypal account is already added

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Open the app
2. Open settings
3. Open Payments
4. If Paypal account already added then remove it
5. Click on 'Add payment method' and click on Paypal
6. Now before adding and saving copy the URL (URL to copy is: https://staging.new.expensify.com/settings/payments/add-paypal-me) and then add any Paypal account
7. Observe that now Paypal account is added and we don't have option to add/update Paypal account
8. Visit URL copied in step 6 from same user in same browser and observe that app allows to add Paypal account even though we already have Paypal account added

Expected Result:

App should not allow to open the add Paypal account if we already have Paypal account added

Actual Result:

App allows to open the add Paypal account using deep link even if we already have paypal account added

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.32.5
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

allows.to.add.paypal.even.if.already.exists.1.mp4

Recording.906.mp4

Expensify/Expensify Issue URL:
Issue reported by: @dhanashree-sawant
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1687489946571709

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01cb50065c59629ed0
• Upwork Job ID: 1673720842042441728
• Last Price Increase: 2023-07-04

[melvin-bot]

Triggered auto assignment to @lschurr (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[jfquevedol2198]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Payments - App allows to add paypal account using deep link even if paypal account is already added

What is the root cause of that problem?

Add Paypal page doens't have validation whether or not PaypalMe is already added.

What changes do you think we should make in order to solve the problem?

If PaypalMe is already added, call to go back.

1. add propTypes in AddPaypalPage component

const propTypes = {
    /** Account details for PayPal.Me */
    payPalMeData: paypalMeDataPropTypes,

    ...withLocalizePropTypes,
};

const defaultProps = {
    payPalMeData: {},
};

2. update AddPaypalPage component by adding payPalMeData by withOnyx

export default compose(
    withLocalize,
    withOnyx({
        payPalMeData: {
            key: ONYXKEYS.PAYPAL,
        }
    }),
)(AddPayPalMePage);

3. add code to go previous page if PaypalMe is already added

useEffect(() => props.payPalMeData.description && Navigation.goBack(ROUTES.SETTINGS_PAYMENTS)
, [props.payPalMeData.description]);

Result

Screen.Recording.2023-06-27.at.8.29.50.AM.mov

What alternative solutions did you explore? (Optional)

N/A

[melvin-bot]

Looks like something related to react-navigation may have been mentioned in this issue discussion.

As a reminder, please make sure that all proposals are not workarounds and that any and all attempt to fix the issue holistically have been made before proceeding with a solution. Proposals to change our DeprecatedCustomActions.js files should not be accepted.

Feel free to drop a note in #expensify-open-source with any questions.

[hungvu193]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Payments - App allows to add paypal account using deep link even if paypal account is already added

What is the root cause of that problem?

We're allowing to edit Paypal user name fromAddPayPalMePage even user already had paypal account.

What changes do you think we should make in order to solve the problem?

Solution 1:
That will be better if we allow user to edit their paypal username, in order to do that, we should add an Edit button inside Modal beside Delete button when user clicked on their Paypal account in AddPayPalMePage.

Solution 2:
Incase we didn't want user to update their paypal account from deeplink. We can add a check inside AddPayPalMePage, if user already had paypal account, then navigate them back to BasePaymentsPage.

What alternative solutions did you explore? (Optional)

N/A

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01cb50065c59629ed0

[melvin-bot]

Current assignee @lschurr is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @eVoloshchak (External)