[HOLD for payment 2023-07-20] [$1000] Attachments flagged as offensive can be viewed and downloaded from attachements previews

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Open expensify app and send an attachement from Account 1 to a group with previous attachement history with Account 2 and 3 as members
2. Go to the attached file using account 2 and flag the attachement "assault"
3. Observe that the attachement is removed from the chat history
4. Now go to account 3 and open the attachement preview by clicking on any other attachements sent prior to the flagged attachement
5. Swipe to the left and observe that the flagged attachement can be viewed and downloaded from attachement preview even if it was removed

Expected Result:

Flagged attachements shouldnt have been accessed once removed

Actual Result:

flagged attachement can be viewed and downloaded from attachement preview even if it was removed

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.32-5
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Screen.Recording.20230626.204615.Chrome.mp4

2023_06_21_05_53_26.mp4

Expensify/Expensify Issue URL:
Issue reported by: @SofoniasN
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1687361182231919

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~019cd43a7818c0b639
• Upwork Job ID: 1673619006955368448
• Last Price Increase: 2023-06-27

[melvin-bot]

Triggered auto assignment to @sonialiap (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[dukenv0307]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Attachments flagged as offensive can be viewed and downloaded from attachements previews

What is the root cause of that problem?

In AttachmentCarousel, we are getting all reportAction without excluding the actions that have the last moderationDecision is pendingRemove

App/src/components/AttachmentCarousel/index.js

Line 155 in 5f5dd02

const actions = [ReportActionsUtils.getParentReportAction(this.props.report), ...ReportActionsUtils.getSortedReportActions(_.values(this.props.reportActions))];

What changes do you think we should make in order to solve the problem?

We should exclude the actions that have the last moderationDecision is pendingRemove by filtering actions with the condition ReportActionUtils.shouldReportActionBeVisible(reportAction, key)

App/src/components/AttachmentCarousel/index.js

Line 155 in 5f5dd02

const actions = [ReportActionsUtils.getParentReportAction(this.props.report), ...ReportActionsUtils.getSortedReportActions(_.values(this.props.reportActions))];

let actions = [ReportActionsUtils.getParentReportAction(this.props.report), ...ReportActionsUtils.getSortedReportActions(_.values(this.props.reportActions))];
actions = _.filter(actions, (action, key) => ReportActionsUtils.shouldReportActionBeVisible(action, key));

What alternative solutions did you explore? (Optional)

_.forEach(actions, (action, key) => {
    if (ReportActionsUtils.shouldReportActionBeVisible(action, key)) {
        htmlParser.write(_.get(action, ['message', 0, 'html']))
    }
});

We also could add a check here to prevent calling htmlParser.write if the action should be visible

App/src/components/AttachmentCarousel/index.js

Line 176 in 5f5dd02

_.forEach(actions, (action) => htmlParser.write(_.get(action, ['message', 0, 'html'])));

Result

Screencast.from.27-06-2023.10.35.03.webm

[sonialiap]

Reproducible, triaging to external

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~019cd43a7818c0b639

[melvin-bot]

Current assignee @sonialiap is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @allroundexperts (External)

[melvin-bot]

📣 @supertech0125! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

1. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
2. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
3. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
   
   Format:

Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>