[HOLD for payment 2023-07-28] [$1000] Room name can be changed by non admin users

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Let User A Create a new room where User B is a member.
2. Using User B click on the room avatar on top.
3. Go to settings
4. Click on room names.
5. Change the name and click the save button.

Expected Result:

Non-admin users can't change room names.

Actual Result:

Non-admin users can change room names

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.32.5
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Room.Error-1-1.1.mp4

Recording.869.mp4

Expensify/Expensify Issue URL:
Issue reported by:@daveSeife
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1686945159267029

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~012941a26a49d6fdc1
• Upwork Job ID: 1673340653182439424
• Last Price Increase: 2023-06-26

[melvin-bot]

Triggered auto assignment to @CortneyOfstad (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[hungvu193]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Room name can be changed by non admin users

What is the root cause of that problem?

in our function to disable rename room, we have this condition:

    shouldDisableRename(linkedWorkspace) {
        if (ReportUtils.isDefaultRoom(this.props.report) || ReportUtils.isArchivedRoom(this.props.report)) {
            return true;
        }

        // The remaining checks only apply to public rooms
        if (!ReportUtils.isPublicRoom(this.props.report)) {
            return false;
        }

        // if the linked workspace is null, that means the person isn't a member of the workspace the report is in
        // which means this has to be a public room we want to disable renaming for
        if (!linkedWorkspace) {
            return true;
        }

So it will allow member to edit room name, if it's not a public room.

What changes do you think we should make in order to solve the problem?

Incase we don't want member to edit the room name, we can delete this condition

        // The remaining checks only apply to public rooms
        if (!ReportUtils.isPublicRoom(this.props.report)) {
            return false;
        }

Incase user went directly to rename page through deeplink, we can show a NotFoundView if user didn't have permission or navigate them back to previous screen.

What alternative solutions did you explore? (Optional)

N/A

[CortneyOfstad]

Was able to recreate this, so getting eyes on it now 👍

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~012941a26a49d6fdc1

[melvin-bot]

Current assignee @CortneyOfstad is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @abdulrahuman5196 (External)