[HOLD for payment 2023-07-17] [$1000] Add Workspace member "Invitation message" page appears when accessing via deeplink

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Open the app
2. Open settings
3. Open workspaces
4. Open any workspace
5. Open members
6. Click on invite
7. Select any user and click next
8. Copy the URL and click on invite
9. Revisite the copied URL and observe that even though no users are selected, we can open invite message page

Expected Result:

App should not allow to open invite message page for workspace without selecting any user to invite.
Suggestion is to display not allowed page if tried to access by deep link

Actual Result:

App allows to open invite message page for workspace without any selected user using deep link

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.31-2
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

allows.invite.message.without.user.selection.mp4

Recording.1082.mp4

Expensify/Expensify Issue URL:
Issue reported by: @dhanashree-sawant
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1686996147729769

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01ed01d5cf4602a878
• Upwork Job ID: 1673409677692813312
• Last Price Increase: 2023-07-03

[melvin-bot]

Triggered auto assignment to @mallenexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[hungvu193]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Invite message page appears when accessing with deeplink without any member selected

What is the root cause of that problem?

In our WorkspaceInviteMessagePage, we are having this condition to show NotFound page.

                <FullPageNotFoundView
                    shouldShow={_.isEmpty(this.props.policy)}
                    onBackButtonPress={() => Navigation.goBack(ROUTES.SETTINGS_WORKSPACES)}
                >

In this case, it's not enough because even when there's no selected member, we still see the page without any NotFound view.

What changes do you think we should make in order to solve the problem?

We should update the shouldShow condition to this, so when there's no selected member, it will display NotFound view.

                <FullPageNotFoundView
                    shouldShow={_.isEmpty(this.props.policy) || _.isEmpty(this.props.invitedEmailsToAccountIDsDraft)}
                    onBackButtonPress={() => Navigation.goBack(ROUTES.SETTINGS_WORKSPACES)}
                >

What alternative solutions did you explore? (Optional)

N/A

[melvin-bot]

Looks like something related to react-navigation may have been mentioned in this issue discussion.

As a reminder, please make sure that all proposals are not workarounds and that any and all attempt to fix the issue holistically have been made before proceeding with a solution. Proposals to change our DeprecatedCustomActions.js files should not be accepted.

Feel free to drop a note in #expensify-open-source with any questions.

[Pujan92]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Invite message page for adding new workspace members is accessible with deeplink without having any selected members.
Due to this user lands on the incomplete screen and sees the invite message textinput and the error Please select at least one member to invite.

What is the root cause of that problem?

We are not validating invitedEmailsToAccountIDsDraft array here(in WorkspaceInviteMessagePage) whether it is empty or not.

App/src/pages/workspace/WorkspaceInviteMessagePage.js

Lines 83 to 85 in 6183609

	componentDidMount() {
	this.focusWelcomeMessageInput();
	}

What changes do you think we should make in order to solve the problem?

We first need to validate invitedEmailsToAccountIDsDraft and if it is empty we should navigate the user to the invite page.

        if(_.isEmpty(this.props.invitedEmailsToAccountIDsDraft)) {
            Navigation.navigate(ROUTES.getWorkspaceInviteRoute(this.props.route.params.policyID));
        }

With this, we need to update the navigation function call for the back button from goBack to navigate of this flow to not take the user to invite-message page on the back button click.

App/src/pages/workspace/WorkspaceInvitePage.js

Line 281 in 2c5e5ae

Navigation.goBack(ROUTES.getWorkspaceMembersRoute(this.props.route.params.policyID));

App/src/pages/workspace/WorkspaceMembersPage.js

Line 409 in 2c5e5ae

Navigation.goBack(ROUTES.getWorkspaceInitialRoute(policyID));

Result

Screen.Recording.2023-06-23.at.10.03.16.PM.mp4

What alternative solutions did you explore? (Optional)

We can show the customized NotFound View by passing the relative key strings() to FullPageNotFoundView.

             <FullPageNotFoundView
                    shouldShow={_.isEmpty(this.props.policy) || _.isEmpty(this.props.invitedEmailsToAccountIDsDraft)}
                    onBackButtonPress={() => Navigation.goBack(ROUTES.SETTINGS_WORKSPACES)}
                    titleKey="workspace.inviteMessage.notHereTitle"
                    subtitleKey="workspace.inviteMessage.notHereSubTitle"
                    shouldShowLink
                    linkKey="workspace.inviteMessage.goToInvite"
                    onLinkPress={() => Navigation.navigate(ROUTES.getWorkspaceInviteRoute(this.props.route.params.policyID))}
                >

Result

Screen.Recording.2023-06-23.at.10.28.54.PM.mov

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01ed01d5cf4602a878

[melvin-bot]

Current assignee @mallenexpensify is eligible for the External assigner, not assigning anyone new.