[HOLD for payment 2023-08-08] [$1000] Attachment preview does not update dynamically

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Open the app and login with user A
2. Open user B report
3. Open app in another device and login with user B
4. From user B, send user A any image attachment
5. From user A, open attachment sent by user B
6. From user B, send new attachment
7. Check in user A that new attachment is not visible in attachment preview, close the preview, open latest attachment
8. From user B, delete the latest attachment
9. Check in user A that we can still access that attachment

Expected Result:

App should dynamically update attachment preview

Actual Result:

App does not dynamically update attachment preview

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number:

Reproducible in staging?: y

Reproducible in production?: y

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

attachment.preview.not.updated.dynamically.mp4

Recording.3211.mp4

Expensify/Expensify Issue URL:

Issue reported by: @dhanashree-sawant

Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1686896537390179

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01507a5371aef23c4a
• Upwork Job ID: 1674577622879911936
• Last Price Increase: 2023-06-30

[melvin-bot]

Triggered auto assignment to @mallenexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[dukenv0307]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Attachment preview does not update dynamically

What is the root cause of that problem?

We don't update page and attachments state in AttachmentCarousel if reportActions is changed.

What changes do you think we should make in order to solve the problem?

We should create componentDidUpdate function to update page and attachments state when reportActions is changed in AttachmentCarousel

componentDidUpdate(prevProps) {
    if (_.isEqual(prevProps.reportActions, this.props.reportActions)) {
        return;
    }

    const {
        page,
        attachments,
    } = this.createInitialState();

    this.setState({
        page,
        attachments
    })
}

What alternative solutions did you explore? (Optional)

NA

Result

Screencast.from.21-06-2023.18.05.51.webm

[mallenexpensify]

Check here

I'm been seeing a lot of bug reports about parts of the app not dynamically updating. I'm going to continue to treat these individually as bugs, if they should be rolled into a project or tracking GH, please 🧵 cc
@Dhanashree Dattaram Sawant
, since it appears you're reporting a lot of 'em

[melvin-bot]

@mallenexpensify Whoops! This issue is 2 days overdue. Let's get this updated quick!

[mallenexpensify]

No action the last time I posted so followed up
https://expensify.slack.com/archives/C01GTK53T8Q/p1687919663462329?thread_ts=1687471385.852519&cid=C01GTK53T8Q

[mallenexpensify]

Thanks for the comment on the Slack thread @dhanashree-sawant.

Can you review the 'update dynamically' bugs you've reported to see if there's a commonality and/or root cause so that we might be able to bunch some together? If not we can manage them individually, it just takes more time/resources to do so.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01507a5371aef23c4a