[HOLD for payment 2023-07-06] [$1000] Login - Page freezes when navigating to secondary login verification link

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Log in to staging.new.expensify.com
2. Log in to staging.expensify.com with the same account as Step 1
3. Add a secondary login via Settings > Account details > Secondary logins
4. Go to verification email and copy the link
5. Change the URL to staging.new.expensify.com/.....
6. Navigate to the link

Expected Result:

Page does not freeze

Actual Result:

Page is freezing

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.30.0

Reproducible in staging?: Yes

Reproducible in production?: Yes

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug6101771_bandicam_2023-06-22_02-56-38-516.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~017f461734f63ec998
• Upwork Job ID: 1672271611349622784
• Last Price Increase: 2023-06-23

[melvin-bot]

Triggered auto assignment to @johncschuster (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[johncschuster]

@lanitochka17 is this test meant to be part of the Add Secondary Login flow? I don't see a flow in new.expensify.com to add a Secondary Login, so I'm wondering why this was tested in this way.

[lanitochka17]

@johncschuster According to the steps with Test Rail https://expensify.testrail.io/index.php?/tests/view/3501015

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~017f461734f63ec998

[melvin-bot]

Current assignee @johncschuster is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @s77rt (External)

[ddrzaic]

Proposal

ThreePaneView.js file, line 72
return ( <View key={route.key} style={[styles.pAbsolute, styles.t0, styles.l0, styles.w100, styles.h100]} > {props.descriptors[route.key].render()} </View> );

this returns a div which overlays the whole page, and that looks like the page is frozen, but in fact, there is a div which is above the page, and if you delete that div, the page is responsive.

Solution

Add ValidateLogin screen to SCREENS constant, and add that case into ThreePaneView.js