[HOLD for payment 2023-07-12] [$1000] emojis are accepted in card name, debit card form field.

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Go to settings -> payments -> add debit card
2. Enter name with emojis on card name form field.
   for eg : " John ❤️😄😄" .
3. Notice it doesn't throw any error.

Expected Result:

inconsistecny in "Legal Name" and "Card Name" form field.
i.e in legal name emojis and special characters aren't allowed. whereas card name form field doesn't check emojis.

Actual Result:

Emojis are allowed in card name field.

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.30-0
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Screen.Recording.2023-06-15.at.4.39.24.PM.mov

Recording.1052.mp4

Expensify/Expensify Issue URL:
Issue reported by: @ashimsharma10
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1686827026457399

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~016b95ce0b884de115
• Upwork Job ID: 1671871155122483200
• Last Price Increase: 2023-06-22

[melvin-bot]

Triggered auto assignment to @isabelastisser (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[Ollyws]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Emojis are accepted for card name.

What is the root cause of that problem?

The ALPHABETIC_CHARS regex isn't using any anchors, but in ALPHABETIC_CHARS_WITH_NUMBER we do use the anchors ^ and $.

What changes do you think we should make in order to solve the problem?

Modify ALPHABETIC_CHARS to have anchors (and also a space and accented characters), eg: ALPHABETIC_CHARS: /^[a-zA-ZÀ-ÿ ]*$/,
This way it matches ALPHABETIC_CHARS_WITH_NUMBER, but without numbers.

What alternative solutions did you explore? (Optional)

None

[Nikhil-Vats]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Emojis are accepted for card name in AddDebitCardPage.

What is the root cause of that problem?

We have two different functions for validating legal name and card name.

App/src/libs/ValidationUtils.js

Lines 148 to 154 in 9e8a151

	function isValidCardName(nameOnCard) {
	if (!CONST.REGEX.ALPHABETIC_CHARS.test(nameOnCard)) {
	return false;
	}
	return !_.isEmpty(nameOnCard.trim());
	}

App/src/libs/ValidationUtils.js

Lines 376 to 379 in 9e8a151

	function isValidLegalName(name) {
	return CONST.REGEX.ALPHABETIC_CHARS_WITH_NUMBER.test(name);
	}

What changes do you think we should make in order to solve the problem?

We should remove one of the functions and use the other function in both places -

ALPHABETIC_CHARS: /[a-zA-Z]+/,
ALPHABETIC_CHARS_WITH_NUMBER: /^[a-zA-ZÀ-ÿ0-9 ]*$/,

We should remove isValidCardName as ALPHABETIC_CHARS is a wrong regex and allows emoji etc. Moreover, we should rename isValidLegalName to isValidName to make it generic and usable in multiple places.

We should also remove ALPHABETIC_CHARS as it is wrong and not used at any other place.

What alternative solutions did you explore? (Optional)

NA

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~016b95ce0b884de115

[melvin-bot]

Current assignee @isabelastisser is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @narefyev91 (External)

[Nodebrute]

Proposal

Please re-state the problem that we are trying to solve in this issue.

emojis are accepted in card name, debit card form field

What is the root cause of that problem?

The regex for Card Name is not checking for errors.

What changes do you think should make in order to solve the problem?

we should throw an error whenever the user enters an emoji in the input field. To achieve this we can add an emoji check where we are validating. We already have an emojis regex in CONST.js we can use it to validate Bank name input field

here add another check || CONST.REGEX.EMOJIS.test(nameOnCard)

In this way we are not messing up with already created regex. We can also add this check in address field that is also accepting emojis

Results

Screen.Recording.2023-06-24.at.12.19.23.AM.mov

What alternative solutions did you explore? (Optional)