[HOLD for payment 2023-07-06] [$1000] Error not displayed for invalid phone number in New Contact Method section

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Go to Settings > Profile > Contact Methods
2. Click "New Contact Method"
3. Enter an invalid phone number (e.g. +1-212-456ww7890)
4. No error is displayed

Expected Result:

The app should display an error for invalid phone numbers to ensure consistency

Actual Result:

The app does not display an error for invalid phone numbers in the New Contact Method section.

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.30-0
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
screen-capture - 2023-06-15T014547.796.webm

Recording.1051.mp4

Expensify/Expensify Issue URL:
Issue reported by: @tewodrosGirmaA
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1686819848909279

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0193d5a8ad70190344
• Upwork Job ID: 1671812275847946240
• Last Price Increase: 2023-06-22

[melvin-bot]

Triggered auto assignment to @conorpendergrast (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[getusha]

I think numbers which have letters in them are in fact valid phone numbers like +1-800-FLOWERS or some letters between. i learned this the hard way after i spent time on this but this may help https://www.quora.com/Why-do-many-public-American-telephone-numbers-have-letters-in-them

[conorpendergrast]

@getusha Maybe, but we don't translate +1-212-456ww7890 into +1-212-456997890. Either way, that's incorrect!

So there are two potential solutions: reject non-numeric phone numbers (ie: show an error when you enter +1-212-456ww7890) or translate the letters into numbers (ie: translate +1-212-456ww7890 into +1-212-456997890`.

I think we can safely use the first solution by validating that field. we seem to reject it on the back-end, as we initially allow that phone number to be entered, and then we silently remove it from the Contact Method list.

[conorpendergrast]

This may have a similar solution to #21230, also reported by @tewodrosGirmaA

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~0193d5a8ad70190344

[melvin-bot]

Current assignee @conorpendergrast is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @mananjadhav (External)