[HOLD for payment 2023-07-26] [$1000] IOS - Offline Mode: Appropriate feedback is not shown on workspace menus that require an internet connection.

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Go to app
2. Disable the devices internet connection
3. Go to settings
4. Go to an existing workspace
5. Go to reimbursement and notice that the Connect bank account button is not shown in offline mode and shows appropriate message that the feature needs an internet connection to be used.
6. Now go to the other menus like, ‘Cards’, ‘Bills’, ‘Invoices’, ‘Travel’ and ‘Bank account’, and notice that they have a Connect Bank Account button that requires an active internet connection but don’t show appropriate feedback back or message during offline mode like we see in ‘Reimbursement’

Expected Result:

Appropriate feedback or messaging is shown on features that need an active internet connection to be used.

Actual Result:

Appropriate feedback is not shown for feature that need an active internet connection to be used.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.25-8

Reproducible in staging?: y

Reproducible in production?: y

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

RPReplay_Final1686726237.1.MP4

2023.06.20.15.54.Img.97931.mp4

Expensify/Expensify Issue URL:

Issue reported by: @daveSeife

Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1686726127882409

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~010cb879bba1c6d08a
• Upwork Job ID: 1676174530647982080
• Last Price Increase: 2023-07-04

[melvin-bot]

Triggered auto assignment to @trjExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[trjExpensify]

Hmm yeah, this is kind of weird. Why only on the reimbursement page do we change the Connect bank account button to this offline message? Also, why did we decide that instead of reducing the opacity of the button and not make it clickable?

CC: @iwiznia @JmillsExpensify

[iwiznia]

I assume no one noticed it.

[trjExpensify]

But why are we using that pattern in the first place versus reducing the opacity to 50% and disabling the button?

[trjExpensify]

^^ no change since my question for Ioni & Mills on Friday, melv!

[melvin-bot]

@trjExpensify Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[trjExpensify]

@JmillsExpensify @iwiznia what do we want to do here?

A. Update all pages to show this message instead of the button, like the Reimbursements page

OR

B. Kill that message and instead disable the button, showing it at 50% opacity.