[HOLD for payment 2023-07-10] [$1000] Web - random QR code is generated on opening share code of room using URL

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. From userA, click on + button and select New room option
2. Fill the details and click on create room option
3. Click on header of room report screen
4. Go to share code and copy the URL
5. From userB (who is not part of room), go to share code using URL ( https://new.expensify.com/r/5701471373675426 )

Expected Result:

Should show 'hmm it's not there...' as user is not part of room

Actual Result:

Users share code shows if user is logged in and if user is not logged in it shows random share code

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.29-6

Reproducible in staging?: yes

Reproducible in production?: yes

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Screen.Recording.2023-06-14.at.11.15.27.AM.1.mov

Recording.787.mp4

Expensify/Expensify Issue URL:

Issue reported by: @gadhiyamanan

Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1686722986231259

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~018651b89a2a819106
• Upwork Job ID: 1673303498370383872
• Last Price Increase: 2023-06-26

[melvin-bot]

Triggered auto assignment to @muttmuure (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[Pujan92]

Proposal

Please re-state the problem that we are trying to solve in this issue.

shows QR code screen for restricted room to non member while using direct url

What is the root cause of that problem?

In the shareCodePage we haven't used FullPageNotFoundView to restrict the user when the report is not available for them.

What changes do you think we should make in order to solve the problem?

Use FullPageNotFoundView component to wrap here which will show 'hmm it's not there...' page while accessing the invalid room for the user. We can also pass the prop shouldShowLink if we want to show Go back to home page link for the Not Found page.

App/src/pages/ShareCodePage.js

Lines 52 to 53 in 2a5aee6

	<ScreenWrapper>
	<HeaderWithBackButton

<ScreenWrapper>
      <FullPageNotFoundView shouldShow={!isReport}>
            <HeaderWithBackButton

Result

Details

[dukenv0307]

Proposal

Please re-state the problem that we are trying to solve in this issue.

show users QR code on opening share code of restricted room using URL

What is the root cause of that problem?

We have a check isReport but we don't use it to display not found page if isReport is false.

What changes do you think we should make in order to solve the problem?

1. Subscrible isLoadingReportData from Onyx with key ONYXKEYS.IS_LOADING_REPORT_DATA
2. We could use FullPageNotFoundView component here to display not found page if the user cannot access the report that has reportID is provided from route.
   

   App/src/pages/ShareCodePage.js

   Line 53 in 342d4fd

   <HeaderWithBackButton

<FullPageNotFoundView shouldShow={!isLoadingReportData && !isReport} shouldShowLink>

shouldShow prop should be !isLoadingReportData && !isReport because when we open with the deep link before signing in we need to wait to report data loads completely to check isReport correctly.

And if isLoadingReportData is true we should display the loading screen to wait to report data loads completely.

What alternative solutions did you explore? (Optional)

[melvin-bot]

@muttmuure Whoops! This issue is 2 days overdue. Let's get this updated quick!

[muttmuure]

Will handle first thing Monday

[muttmuure]

Looks like this one is fixed: