[HOLD for payment 2023-07-06] Android- Chat- The user is not navigated to the chat screen after opening chat from notification

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Close the NewDot app
2. Wait for ~1 minute
3. Send a message from B to A. Push notification should appear
4. Double-tap the notification. It should navigate the user to the correct chat, and the new message should be available.

Expected Result:

The user is expecting that the app opens and then the user is redirected to the chat screen in one-on-one chat bar

Actual Result:

The user is been sent to the homepage of the app when the app is opened through the chat message received from the notification bar

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.29.0

Reproducible in staging?: Yes

Reproducible in production?: Yes

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug6095699_mobizen_20230616_150002.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team / @Victor-Nyagudi

Slack conversation:

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0169b8f4b5af31c852
• Upwork Job ID: 1671205349345284096
• Last Price Increase: 2023-06-20

[melvin-bot]

Triggered auto assignment to @adelekennedy (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[arosiclair]

This regression reached prod but should have been caught in regression tests. Giving Applause the benefit of the doubt, I think this is what happened:

Maybe they are clicking the notification with the chat already open. Right now, clicking the notification just opens the app and doesn’t navigate. So if they already had the chat open, it’d seem like it worked correctly

[arosiclair]

Seems that it works while the app is alive, but not while killed:

screen-20230620-131107_2.mp4

I'll look into this

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~0169b8f4b5af31c852

[melvin-bot]

Triggered auto assignment to Contributor Plus for review of internal employee PR - @mollfpr (Internal)

[arosiclair]

As suspected this was caused by the navigation reboot. Specifically, we're no longer waiting for the NavigationContainer to be ready. Additionally, we're still making a call to Navigation.setDidTapNotification() which does not exist and causes an error (source).

There's a few thing we need to do here:

• Fix the bug
• Add logging for notification click handling so we can better debug this in the future
• Update regression test steps to select a different chat before testing notification click through and also to test click through with the app killed

[melvin-bot]

Looks like something related to react-navigation may have been mentioned in this issue discussion.

As a reminder, please make sure that all proposals are not workarounds and that any and all attempt to fix the issue holistically have been made before proceeding with a solution. Proposals to change our DeprecatedCustomActions.js files should not be accepted.

Feel free to drop a note in #expensify-open-source with any questions.