[HOLD for payment 2023-07-26] [$1000] Chat - Inconsistent behavior on deleting message that have reply/thread

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Go to any chat on new.expensify.com
2. Write and send a message
3. Reply to your own message, it will lead you to thread page(good)
4. Go back to conversation page and delete the message
5. It says "[deleted message] 1 reply" (good), delete that message again.
6. It will remove the [deleted message] with the 1 reply temporarily, then go to the thread that is created when you reply to the message
7. Go back to the conversation, observe the "[deleted message]" reappeared(bad)
   Note that: I am not saying the deleted message is reappearing but the label "[deleted message]" is appearing again after it is deleted

Expected Result:

When the [deleted message] is deleted it should permanently be not shown, or it always shouldn't allow the label [deleted message] to be deleted based on Expensify rule. At least, it should be consistent.

Actual Result:

Now, it is not consistent. When you delete the "[deleted message]" label in the conversation it will delete temporarily, then after you get in to the thread and get back to the conversation you will see it reappearing.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

**Version Number:**1.3.28-5

Reproducible in staging?: y

Reproducible in production?: y

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Screenshare.-.2023-06-13.11_18_59.AM.1.mp4

Recording.784.mp4

Expensify/Expensify Issue URL:

Issue reported by: @KALLL

Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1686645553886709

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~019b1d6662d4b09fb2
• Upwork Job ID: 1671865093908606976
• Last Price Increase: 2023-06-22

[melvin-bot]

Triggered auto assignment to @joekaufmanexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[hungvu193]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Chat - Inconsistent behavior on deleting message that have reply/thread

What is the root cause of that problem?

We are checking condition to show the Delete button inside ContextMenu here:

App/src/pages/home/report/ContextMenu/ContextMenuActions.js

Lines 267 to 273 in e6c2704

	shouldShow: (type, reportAction, isArchivedRoom, betas, menuTarget, isChronosReport, reportID) =>
	// Until deleting parent threads is supported in FE, we will prevent the user from deleting a thread parent
	type === CONTEXT_MENU_TYPES.REPORT_ACTION &&
	ReportUtils.canDeleteReportAction(reportAction, reportID) &&
	!isArchivedRoom &&
	!isChronosReport &&
	!ReportActionUtils.isMessageDeleted(reportAction),

In this case, after message is deleted, we deleted the reportAction by updating the optimisticData to this:

    const deletedMessage = [
        {
            type: 'COMMENT',
            html: '',
            text: '',
            isEdited: true,
            isDeletedParentAction: true,
        },
    ];

But in isMessageDeleted we are checking isDeletedParentAction inside originalMessage

function isMessageDeleted(reportAction) {
    return lodashGet(reportAction, 'originalMessage.isDeletedParentAction', false);
}

What changes do you think we should make in order to solve the problem?

We should also update the originalMessage's isDeletedParentAction property to true in our optimisticReportActions data in here
Something like this:

    const optimisticReportActions = {
        [reportActionID]: {
            pendingAction: CONST.RED_BRICK_ROAD_PENDING_ACTION.DELETE,
            previousMessage: reportAction.message,
            message: deletedMessage,
            originalMessage: {
                isDeletedParentAction: true,
                html: '',
                text: '',
            },
            errors: null,
        },
    };

What alternative solutions did you explore? (Optional)

We can also use the message prop to identify if the message is deleted or not

function isMessageDeleted(reportAction) {
    return lodashGet(reportAction, ['message', 0, 'isDeletedParentAction'], false);
}

[joekaufmanexpensify]

i can reproduce this. I think this is related to the above issue. Sense checking next steps here.

[joekaufmanexpensify]

Still determining next steps

[joekaufmanexpensify]

Was advised on the other issue, that this one was out of scope there. Here is my reproduction of this bug. For expected behavior, once you delete a parent thread message. We should immediately change the comment actions menu to show only "reply in thread" and "mark Unread", which is what is shows once you leave the leave the chat and come back.

2023-06-20_16-43-23.mp4

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~019b1d6662d4b09fb2

[melvin-bot]

Current assignee @joekaufmanexpensify is eligible for the External assigner, not assigning anyone new.