[HOLD for payment 2023-06-29] CRITICAL [SNH]: Chat - Status “User is typing” shows the email instead of the username

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

Pre-condition: User logged in with 2 different accounts in different devices

1. As account B, type in the composer and check the area under the compose box in account A device
2. Verify there's a message indicated that user B is typing

Expected Result:

Message is composed by "{Name} is typing..." (E.g: John is typing). The user email is NOT mentioned if the user has set a name

Actual Result:

Status “User is typing” shows the email instead of the username

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.29.0

Reproducible in staging?: Yes

Reproducible in production?: No

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug6096210_User-typing-email-name.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01a8a911757d8cf39e
• Upwork Job ID: 1675915112774844416
• Last Price Increase: 2023-07-03

[OSBotify]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @robertjchen (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[c3024]

Proposal

"User email is typing" appears instead of "Username is typing"

What is the root cause of the problem?

personalDetails has accountIDs as keys. Hence here in PersonalDetails.js, lodashGet(personalDetails, login) would not fetch the corresponding object.
https://github.com/Expensify/App/blob/83ab0160a3b5c385fd26fffe20bdbccabf9249c0/src/libs/actions/PersonalDetails.js#LL40C5-L41C1

What needs to be changed?

Change the line to

const userDetails = personalDetail || _.find(personalDetails, (detail) => detail.login === login) || lodashGet(personalDetails, login);

so that the correct accountID can be found by comparing login with each object login and the fullName is obtained correctly.
https://github.com/Expensify/App/blob/83ab0160a3b5c385fd26fffe20bdbccabf9249c0/src/libs/actions/PersonalDetails.js#LL46C1-L48C56

What other alternatives did you explore?

None.

Uploading Screen Recording 2023-06-17 at 7.57.17 AM.mov…

[dhairyasenjaliya]

Proposal

Please re-state the problem that we are trying to solve in this issue.

• Chat - Status “User is typing” shows the email instead of the username \

What is the root cause of that problem?

• The root cause is we are not passing personalDetail of participate report and we are using the function getDisplayName without it which returns the default email to display rather than the full name

What changes do you think we should make in order to solve the problem?

• We need to pass new props to reportRecipient that contains personalDetail of Recipient inside the ReportActionCompose.js which contains first name, last name

• And on ReportTypingIndicator.js we need to pass props.reportRecipient to getDisplayName()

• No additional loop needed to find the username

// ReportActionCompose.js

<ReportTypingIndicator
+  reportRecipient={reportRecipient}
   reportID={this.props.reportID}
/>

//ReportTypingIndicator.js

<TextWithEllipsis
-   leadingText={PersonalDetails.getDisplayName(usersTyping[0])}
+   leadingText={PersonalDetails.getDisplayName(usersTyping[0], props.reportRecipient)}
>

Result

[Pujan92]

It seems from the backend in the pusherEvent we need to set accountID instead of loginId.

App/src/libs/actions/Report.js

Lines 119 to 120 in 83ab016

	Pusher.subscribe(pusherChannelName, Pusher.TYPE.USER_IS_TYPING, (typingStatus) => {
	const normalizedTypingStatus = getNormalizedTypingStatus(typingStatus);

If accountId is passed then the below code will fetch the details correctly with the updated onyx structure for the personalDetailsList.

App/src/libs/actions/PersonalDetails.js

Line 40 in 83ab016

const userDetails = personalDetail || lodashGet(personalDetails, login);