[Awaiting Checklist Completion] [$1000] Web - The reveal /hide button text is cut off in offline mode and doesn't disappears dynamically

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Go to staging dot on web chrome and login with User A (On another window login with User B)
2. From User A, send a message to User B and from User B mark the same message as assault
3. On User A, go offline and delete the message you sent earlier and notice that the button text is cut from the between. (Cutting the button text makes it look weird since we don't normally see any button texts that are cut from between)
4. You can see still the button reveal/hide is present. But now click on any other chat and return back to the previous chat and notice that the button disappears. Thus, the button should have dynamically disappeared when the user A deleted the message earlier.

Expected Result:

The reveal /hide button text should not be cut off in the first place. Also, the button should have disappeared dynamically when the user has deleted the message in offline mode.

Actual Result:

The reveal /hide button text is cut off and doesn't disappear dynamically

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.27.3

Reproducible in staging?: yes

Reproducible in production?: yes

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

error-2023-06-10_21.31.18.1.mp4

Recording.737.mp4

Expensify/Expensify Issue URL:

Issue reported by: @priya-zha

Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1686412725163069

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~014c79e15242357a09
• Upwork Job ID: 1670827258725896192
• Last Price Increase: 2023-07-03

[melvin-bot]

Triggered auto assignment to @twisterdotcom (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[dukenv0307]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The reveal button appears after deleting message in offline mode, but it is hidden after open an other report and go back

What is the root cause of that problem?

When deleting a comment, we update optimistic data of report action and remove all moderationDecisions of the message

App/src/libs/actions/Report.js

Lines 787 to 798 in d396430

	function deleteReportComment(reportID, reportAction) {
	const reportActionID = reportAction.reportActionID;
	const deletedMessage = [
	{
	type: 'COMMENT',
	html: '',
	text: '',
	isEdited: true,
	isDeletedParentAction: true,
	},
	];
	const optimisticReportActions = {

After optimistic data is merged in Onyx, useEffect is triggered in ReportActionItem, and then because moderationDecision is empty after deleting, useEffect returns here, and moderationDecision state is still last decision of message. That is the reason, reveal message button still display after deleting comment in offline

App/src/pages/home/report/ReportActionItem.js

Lines 136 to 138 in d396430

	if (!props.action.actionName === CONST.REPORT.ACTIONS.TYPE.ADDCOMMENT || _.isEmpty(props.action.message[0].moderationDecisions)) {
	return;
	}

After we open other chat and go back, moderationDecision has default value CONST.MODERATION.MODERATOR_DECISION_APPROVED, useEffect doesn't update this state because now props.action.message[0].moderationDecisions is empty.

App/src/pages/home/report/ReportActionItem.js

Line 108 in d396430

const [moderationDecision, setModerationDecision] = useState(CONST.MODERATION.MODERATOR_DECISION_APPROVED);

That makes hasBeenFlagged is false with moderationDecision is CONST.MODERATION.MODERATOR_DECISION_APPROVED and then reveal message button is hidden

App/src/pages/home/report/ReportActionItem.js

Line 263 in d396430

const hasBeenFlagged = !_.contains([CONST.MODERATION.MODERATOR_DECISION_APPROVED, CONST.MODERATION.MODERATOR_DECISION_PENDING], moderationDecision);

What changes do you think we should make in order to solve the problem?

• If delete message in offline mode still need to show reveal button, we should keep moderationDecisions of message in optimisticReportActions in deleteReportComment function by updating like this

const deletedMessage = [
        {
            type: 'COMMENT',
            html: '',
            text: '',
            isEdited: true,
            isDeletedParentAction: true,
            moderationDecisions: reportAction.message[0].moderationDecisions
        },
    ];

• If not, we could update useEffect to reset moderationDecision state to CONST.MODERATION.MODERATOR_DECISION_APPROVED if action is addComment and props.action.message[0].moderationDecisions is empty

What alternative solutions did you explore? (Optional)

[twisterdotcom]

Okay, I agree. @dangrous - do you agree? This is pretty edge case but that's what open source bug reporting is for.

The reveal /hide button text should not be cut off in the first place. Also, the button should have disappeared dynamically when the user has deleted the message in offline mode.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~014c79e15242357a09

[melvin-bot]

Current assignee @twisterdotcom is eligible for the External assigner, not assigning anyone new.