[HOLD for payment 2023-07-14] [$1000] Settings - On Share Code page number is not displayed in formatted as we displayed on other pages

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Login to ND (with number login)
2. Navigate to settings
3. Navigate to share code screen
4. Notice subtitle on QR view shows phone number with email extension (not formatted as we can see on setting page)

Expected Result:

Phone number should be formatted as we can see on profile page

Actual Result:

Phone number is not formatted as we does on other pages like (profile page ,account close page )

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.16-3

Reproducible in staging?: yes

Reproducible in production?: yes

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Expensify/Expensify Issue URL:

Issue reported by: @dhairyasenjaliya

Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1684739607316259

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01d6e5878ab0553a59
• Upwork Job ID: 1671639469433528320
• Last Price Increase: 2023-06-28

[melvin-bot]

Triggered auto assignment to @alexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[dhairyasenjaliya]

Proposal

Please re-state the problem that we are trying to solve in this issue.

• On Share Code page number is not displayed in formatted as we displayed on other pages

What is the root cause of that problem?

• The root cause is we are not converting the login/email to display in formatted

What changes do you think we should make in order to solve the problem?

• We need to add apply formatPhoneNumber function to formatted phone number to remove @Expensify extension on ShareCodePage.js
• Optionally we can also ise

const formattedPhone = this.props.formatPhoneNumber(this.props.session.email)
 <QRShareWithDownload  subtitle={isReport ? subtitle : formattedPhone}    /> 

[alexpensify]

This one is on my test list

[alexpensify]

I'll be testing soon!

[alexpensify]

I've reviewed the Slack convo and will be assigning it to External since this one is not a dupe.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01d6e5878ab0553a59