[$1000] Android - Settings - Long welcome message on android is seen at the bottom whereas on mweb chrome , it is shown from top

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Go to mweb chrome and create a room using any workspace
2. Go to header > Settings > welcome message and enter a long message so that the text occupies all the empty space
3. Go back and again click on welcome message to view the message
4. Notice that on mweb chrome, the sentence is seen from the top only
5. But now, go to android and go to the same room. Go to welcome message and notice that the first few lines of sentences are hidden and the bottom part of the texts are displayed at the screen due to the vertical scrollbar present at the bottom by default

Expected Result:

There should be consistency between the long welcome message that is displayed on mweb and android

Actual Result:

Long welcome message on android is seen at the bottom whereas on mweb chrome , it is shown from top

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.27.7

Reproducible in staging?: yes

Reproducible in production?: yes

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Record_2023-06-14-23-53-46.mp4

Expensify/Expensify Issue URL:

welcome.1.mp4

https://expensify.slack.com/archives/C049HHMV9SM/p1686247152994819

Issue reported by: @priya-zha

Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1686247152994819

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01e83cbdd7fb9aa5b3
• Upwork Job ID: 1669641544505233408
• Last Price Increase: 2023-06-16

[melvin-bot]

Triggered auto assignment to @dylanexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[dylanexpensify]

Reviewing now!

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01e83cbdd7fb9aa5b3

[melvin-bot]

Current assignee @dylanexpensify is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @Santhosh-Sellavel (External)

[Nodebrute]

Hey, I don't see a new room option in FAB. Is this available only in high-traffic accounts?

[tienifr]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Long welcome message on android is seen at the bottom whereas on mweb chrome , it is shown from top

What is the root cause of that problem?

For native input, the cursor is set at end by default. But for web, mweb or desktop it's set at the beginning

App/src/pages/workspace/WorkspaceInviteMessagePage.js

Line 134 in bd0e843

// Below condition is needed for web, desktop and mweb only, for native cursor is set at end by default.

What changes do you think we should make in order to solve the problem?

We should have the logic to set the cursor at the end of the input and scroll to the bottom as well.

The logic seem like what we did in WorkspaceInviteMessagePage

App/src/pages/workspace/WorkspaceInviteMessagePage.js

Lines 131 to 140 in bd0e843

	focusWelcomeMessageInput() {
	this.focusTimeout = setTimeout(() => {
	this.welcomeMessageInputRef.focus();
	// Below condition is needed for web, desktop and mweb only, for native cursor is set at end by default.
	if (this.welcomeMessageInputRef.value && this.welcomeMessageInputRef.setSelectionRange) {
	const length = this.welcomeMessageInputRef.value.length;
	this.welcomeMessageInputRef.setSelectionRange(length, length);
	}
	}, CONST.ANIMATED_TRANSITION);
	}

and add the additional logic to scroll the input to bottom like welcomeMessageInputRef.current.scrollTop=welcomeMessageInputRef.current.scrollHeight

Result

Screen.Recording.2023-06-16.at.16.50.24.mov