[HOLD for payment 2023-07-12] [$1000] Web - Chat - Flagged attachment are collapsed when reacted with emojis

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Login with user A and go to a chat with user B
2. Send an attachment ( picture/pdf) to user B
3. On user B, first flag the attachment as bullying. Next, ( this is an important step) click on the reveal message. Now react with any emojis
4. Notice the attachment is now hidden.

Expected Result:

Flagged attachment should not be collapsed when reacted with emojis

Actual Result:

Flagged attachments are collapsed when reacted with emojis

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.27.6

Reproducible in staging?: yes

Reproducible in production?: yes

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Screen.Recording.2023-06-08.at.3.13.21.PM.1.mov

Recording.724.mp4

Expensify/Expensify Issue URL:

Issue reported by: @ashimsharma10

Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1686217468053799

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0192768e5414216425
• Upwork Job ID: 1670794643847507968
• Last Price Increase: 2023-06-19

[melvin-bot]

Triggered auto assignment to @muttmuure (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[hungvu193]

Seems regression from #20737
That's exact case that I mentioned, is this expected? @aimane-chnaif

[aimane-chnaif]

It's not a regression. We agreed to restore hidden state back when refresh page. And this already happens in production, while that PR is on staging.
Though I am not able to reproduce this on latest main. Instead another weird bug happens which is not related to that PR:
Flagged attachment completely disappearing. And flagged text message isn't hidden at all.

[hungvu193]

Seems this was logged before that pr hit stagging, I couldn't reproduce on latest main as well
I'm able to reproduce it after try to delete cache.

[ashimsharma10]

@hungvu193 are you sure the same issue mentioned above is reproduced?

[aimane-chnaif]

I think there were another recent changes related to flag behavior. Maybe backend updates.
After some time, flag cancels.

Screen.Recording.2023-06-15.at.2.34.17.PM.mov

[muttmuure]

I've been trying to reproduce this but I'm seeing that the message isn't being hidden at all

[muttmuure]

Ah OK it was just taking a while

[muttmuure]

OK yep this is reproducible - note it only happens with attachments, when you flag a comment using an option that removes the comment from view, and when you reveal the comment when it is hidden and add an emoji