[HOLD for payment 2023-07-05] [$1000] Contact Method - Email already exist message appears for a second on click of add button

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Go to settings > profile > contact method
2. Click on new contact method
3. Enter any email and click on Add

Expected Result:

Email already exist message appears for a second when go to previous screen

Actual Result:

Should not show email already exist message

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.26.1

Reproducible in staging?: yes

Reproducible in production?: yes

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Screen_Recording_20230608_113934_New.Expensify.mp4

RPReplay_Final1686588833.1.MP4

Expensify/Expensify Issue URL:

Issue reported by: @gadhiyamanan

Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1686204823445989

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~012a68d826980a204b
• Upwork Job ID: 1668596757704597504
• Last Price Increase: 2023-06-13

[melvin-bot]

Triggered auto assignment to @bfitzexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[allroundexperts]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Error message appears for a brief moment when form is submitted

What is the root cause of that problem?

The root cause of the issue is that the validate function re-runs when the form is submitted. Once submitted, the new email gets added to the list of logins by optimistic data. As such the validation rule defined here returns true, thus causing the error to show up.

The validate method should not be called once the form is submitted. It gets called because we're supplying onValidate function as a param to the useEffect defined here. Since the onValidate callback changes itself if the validate prop changes, and the validate function is not wrapped inside the callback (https://github.com/allroundexperts/Expensify/blob/035783a7984e0214677b5364d9351c968887bf58/src/pages/settings/Profile/Contacts/NewContactMethodPage.js#L78), the re-render happens after the form submits.

What changes do you think we should make in order to solve the problem?

We need to wrap the validate function here inside a useCallback such that it does not change with each render. This will cause the onValidate to not run after the form is submitted.

What alternative solutions did you explore? (Optional)

We can also remove the onValidate param in the useEffect here to fix this problem.

[bfitzexpensify]

Reproduced.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~012a68d826980a204b

[melvin-bot]

Current assignee @bfitzexpensify is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @aimane-chnaif (External)