[HOLD for payment 2023-07-28] [$1000] Offline - Thread - Count reply does not update when completing or reopening a task

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Open any report
2. Create a task
3. Tick checkbox complete task
4. Open the report action task see 1 reply
5. Open parent report see 1 reply under task

Expected Result:

The number of replies must increase after changing the checkbox

Actual Result:

Only after opening the report the number of replies increase

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.26.1

Reproducible in staging?: yes

Reproducible in production?: yes

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Screen.Recording.2023-06-07.at.09.33.55.1.mov

Recording.3069.mp4

Expensify/Expensify Issue URL:

Issue reported by: @namhihi237

Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1686105205074489

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01090ab015f7de42e1
• Upwork Job ID: 1668226471256403968
• Last Price Increase: 2023-07-03

[melvin-bot]

Triggered auto assignment to @abekkala (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Triggered auto assignment to @bfitzexpensify (NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[dukenv0307]

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

When we complete or re-open task, it has two problems

1. We don't update optimisticData for parent report action to update the count reply immediately

What changes do you think we should make in order to solve the problem?

• Update optimisticData for parent report action by using updateOptimisticParentReportAction function

1. In reopenTask and completeTask function get parentReportAction from taskReportID
2. Call updateOptimisticParentReportAction to get optimistic data of parent report action
3. Add this data from optimisticData

Example for completeTask

optimisticData.push({
    onyxMethod: Onyx.METHOD.MERGE,
    key: `${ONYXKEYS.COLLECTION.REPORT_ACTIONS}${report.parentReportID}`,
    value: {
        [parentReportAction.reportActionID]: ReportUtils.updateOptimisticParentReportAction(parentReportAction, completedTaskReportAction.create, CONST.RED_BRICK_ROAD_PENDING_ACTION.ADD),
    },
  });

What alternative solutions did you explore? (Optional)

[bfitzexpensify]

Reproduced