[HOLD for payment 2023-06-28] [$1000] Settings - Zip/ Pin code validation is case sensitive

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

Action Performed:

1. Open the app
2. Open settings
3. Open profile
4. Open personal details
5. Open Home address
6. Change country to 'Ascension Island'
7. Insert same format zip code but in lower case and observe that it throws validation error.

Expected Result:

The Zip/ Pin code should be uppercased on the background without user noticing and then we can run the verification making the case sensitiveness irrelevant.

Actual Result:

Zip/ Pin code validation is case sensitive

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.26.1

Reproducible in staging?: yes

Reproducible in production?: yes

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

case.sensitive.zipcode.error.mp4

Recording.3066.mp4

Expensify/Expensify Issue URL:

Issue reported by: @dhanashree-sawant

Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1686066243272029

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01ebaa85cf62804d03
• Upwork Job ID: 1668213774703255552
• Last Price Increase: 2023-06-12

[melvin-bot]

Triggered auto assignment to @johncschuster (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[dukenv0307]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Zip/ Pincode validation is case sensitive

What is the root cause of that problem?

Example for Ascension Island Country

App/src/CONST.js

Lines 1570 to 1573 in 82ce35f

	AC: {
	regex: /^ASCN 1ZZ$/,
	samples: 'ASCN 1ZZ',
	},

We are using this regex to check if the zipcode is valid or not. And this regex is accepted if the input is uppercase

What changes do you think we should make in order to solve the problem?

We should uppercase the input before validating and saving zipcode
In here

App/src/pages/settings/Profile/PersonalDetails/AddressPage.js

Line 107 in 82ce35f

if (!countrySpecificZipRegex.test(values.zipPostCode.trim())) {

and

App/src/pages/settings/Profile/PersonalDetails/AddressPage.js

Line 60 in 82ce35f

PersonalDetails.updateAddress(values.addressLine1.trim(), values.addressLine2.trim(), values.city.trim(), values.state.trim(), values.zipPostCode.trim(), values.country);

Update

values.zipPostCode.trim()

to

values.zipPostCode.trim().toUpperCase())

What alternative solutions did you explore? (Optional)

In some countries, we only have some options in zip code field (ex: Ascension Island Country, we only have 1 option is ASCN 1ZZ ). So with these country, we can use an option selector instead of input field

[eh2077]

It looks like country zip code is case sensitive and would like to tag @Prince-Mendiratta to confirm as you added the feature #14958

[huzaifa-99]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The zip codes in the address form are case sensitive

What is the root cause of that problem?

Our zip code regex for countries is designed to be case-sensitive for all countries other than Montserrat.

We currently have ~42 (-1 Montserrat) countries with alphabets in zip codes, all case-sensitive.

What changes do you think we should make in order to solve the problem?

Most countries use uppercase zipcodes for ease of processing, but lowercase ones also work. We can allow case-insensitive zip codes for all countries by adding an i flag in the regex, so for example, the regex for Ascension Island will become

AC: {
    regex: /^ASCN 1ZZ$/i,
    // ...

which will match the lower and upper case alphabets.

Optional:

• Update the zip code sample values with lowercase zipcode examples.

What alternative solutions did you explore? (Optional)

N/A

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01ebaa85cf62804d03

[melvin-bot]

Current assignee @johncschuster is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @abdulrahuman5196 (External)