[Polish] Make the RHP animations always working on web and they are smooth

[mountiny]

Clean up for the #11768

Problem

Because of using stack navigation for all the pages in the App, when we close a modal we lose the information about the route and what should be rendered so its not easy to animate closing the modal. We are showing or closing the RHP modal abruptly because of that.

Additionally if you navigate to a deeplink RHP like settings/security, we use replace to go up in the stack but those pages are not in the stack yet so animating to them is trickier.

Additionally, thr animations are not smooth at all time which you can see on an attached video here

Screen.Recording.2023-06-07.at.09.46.36.mov

Why is it important

Animations give a better feel to the app and its important to keep the animations consistent

Solution

Lets ensure:

• we can have the same animation to the RHP modal for any open and close action
• the animations are performant and smooth

[melvin-bot]

Triggered auto assignment to @MitchExpensify (NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details.

[WoLewicki]

Commenting

[mountiny]

Focusing on bugs now