[HOLD for payment 2023-06-28] [$1000] Chat - Email address is displayed instead of 'You' when pulling up the reaction detail

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Issue found when executing PR #20034

Action Performed:

Precondition: Account has no username.

1. Go to https://staging.new.expensify.com/
2. Go to any chat.
3. Add a reaction to the message.
4. Hover over the reaction.
5. Long press on the reaction.

Expected Result:

'You' is displayed for the user without username who adds a reaction to the message.

Actual Result:

The user email address is displayed, although it shows 'You' when hovering over the reaction.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.24.4

Reproducible in staging?: yes

Reproducible in production?: yes

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug6082167_Screen_Recording_20230606_210835_Chrome.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~012f8da03bb1a41b0a
• Upwork Job ID: 1666641527111053312
• Last Price Increase: 2023-06-08

[melvin-bot]

Triggered auto assignment to @arielgreen (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[Pujan92]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Current user is not displayed as You in the reactions list

What is the root cause of that problem?

In the PopoverReactionsList we are not passing current user details and shouldChangeUserDisplayName parameter in the getPersonalDetailsByIDs function call here.

App/src/pages/home/report/ReactionList/PopoverReactionList.js

Line 169 in 08b1bf6

const users = PersonalDetailsUtils.getPersonalDetailsByIDs(reactionUsers);

What changes do you think we should make in order to solve the problem?

We need to pass extra 2 parameters here which will replace the display name as You for the current user.

const users = PersonalDetailsUtils.getPersonalDetailsByIDs(reactionUsers, this.props.currentUserPersonalDetails.accountID, true);

Same we are passing for the ReactionTooltipContent

App/src/components/Reactions/ReactionTooltipContent.js

Line 36 in 08b1bf6

() => PersonalDetailsUtils.getPersonalDetailsByIDs(props.accountIDs, props.currentUserPersonalDetails.accountID, true),

Result

[dukenv0307]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Chat - Email address is displayed instead of 'You' when pulling up the reaction detail

What is the root cause of that problem?

In PopoverReactionList gets users by calling getPersonalDetailsByIDs function without currentUserAccountID and shouldChangeUserDisplayName params. So that all users displays email address or username in PopoverReactionList

App/src/pages/home/report/ReactionList/PopoverReactionList.js

Line 169 in 08b1bf6

const users = PersonalDetailsUtils.getPersonalDetailsByIDs(reactionUsers);

What changes do you think we should make in order to solve the problem?

We should pass currentUserAccountID is the ID of current that is logging and shouldChangeUserDisplayName is true when we call getPersonalDetailsByIDs in PopoverReactionList by the same way we get users in ReactionTooltipContent

App/src/pages/home/report/ReactionList/PopoverReactionList.js

Line 169 in 08b1bf6

const users = PersonalDetailsUtils.getPersonalDetailsByIDs(reactionUsers);

App/src/components/Reactions/ReactionTooltipContent.js

Line 36 in 08b1bf6

() => PersonalDetailsUtils.getPersonalDetailsByIDs(props.accountIDs, props.currentUserPersonalDetails.accountID, true),

What alternative solutions did you explore? (Optional)

[arielgreen]

reproduced

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~012f8da03bb1a41b0a

[melvin-bot]

Current assignee @arielgreen is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @abdulrahuman5196 (External)