[HOLD for payment 2023-07-20] [$1000] Able to invite logged in phone number to WS and throws error message for all other invited members

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Open the app
2. Login with phone number
3. Open settings
4. Open workspaces
5. Open any workspace
6. Open members
7. Click in invite
8. Search for same number (with which you are logged in ) with @expensify.sms in end.
9. Select the result, select other users too and invite

Expected Result:

Display “not found” for invalid phone numbers that are submitted with @expensify.sms.
Display “not found” or a generic error for other emails with the @expensify.sms domain.
Display valid phone numbers for @expensify.sms.

Actual Result:

App allows to add current logged in phone number user in workspace if we add @expensify.sms behind it and after invite, provides the error.

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.24-2
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

allows.to.add.same.user.if.added.@expensify.sms.behind.mp4

Recording.889.mp4

Expensify/Expensify Issue URL:
Issue reported by: @dhanashree-sawant
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1685700872311559

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~018cc2e6b38ce41553
• Upwork Job ID: 1673286555517894656
• Last Price Increase: 2023-07-03

[melvin-bot]

Triggered auto assignment to @muttmuure (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[hungvu193]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Able to invite logged in phone number to WS and throws error message for all other invited members

What is the root cause of that problem?

We are excluding the current login user from invite options, with user that logged in with phone number , current login will have the format: {country_code}{phone_number}{sms_domain}, meanwhile the phone in this issue has the format {phone_number}{sms_domain}, because it's still valid phone number and isn't included in exclude logins, that why we can still select it. Later when we sent the request to server, it will response error because of sever validation.

What changes do you think we should make in order to solve the problem?

With user logged in with phone number we should add more exclude login to loginOptionsToExclude inside getOptions function:

const userHasPhonePrimaryEmail = Str.endsWith(currentUserLogin, CONST.SMS.DOMAIN);
if (userHasPhonePrimaryEmail) {
 const currentUser = LocalePhoneNumber.formatPhoneNumber(currentUserLogin)
 const phoneNumberWithoutDomain = currentUser.replace(/ /g,'');

   loginOptionsToExclude.push({
        login: `${phoneNumberWithoutDomain}${CONST.SMS.DOMAIN}`
    })


   if (phoneNumberWithoutDomain.startsWith('0')) {
    loginOptionsToExclude.push({
        login: `${phoneNumberWithoutDomain.slice(1)}${CONST.SMS.DOMAIN}`
    })
}


    loginOptionsToExclude.push({
        login: `${LoginUtils.appendCountryCode(phoneNumberWithoutDomain)}${CONST.SMS.DOMAIN}`
    })
}

For example user has phone number 0335125123 we will need to exclude three more phone numbers:
0335125123@expensify.sms
335125123@expensify.sms
+840335125123@expensify.sms

What alternative solutions did you explore? (Optional)

N/A

[muttmuure]

@expensify.sms is not a public facing account name, so while this is probably unexpected, it is an extreme edge case.

I'm going to think about it a bit moer

[melvin-bot]

@muttmuure Whoops! This issue is 2 days overdue. Let's get this updated quick!

[muttmuure]

I can't reproduce this one - it might have been fixed already.