[HOLD for payment 2023-06-21] [$1000] Web - Room - Visibility subtitle is wrong for public room

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Click on + icon
2. Choose new room option
3. Enter room name
4. Choose visibility as public and check subtitle below the dropdown (Anyone can find this room)
5. Click on create room button
6. Go to room
7. Click on header to see Details
8. Go to Settings and check text in Visibility section

Expected Result:

For public room text should be Anyone can find this room

Actual Result:

Wrong text shows(People invited to this room can find it)

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.23.6

Reproducible in staging?: yes

Reproducible in production?: yes

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Screen.Recording.2023-05-31.at.3.09.31.PM.mov

Recording.2963.mp4

Expensify/Expensify Issue URL:

Issue reported by: @gadhiyamanan

Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1685526019865179

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01005cb0382b9b4e71
• Upwork Job ID: 1666314654139772928
• Last Price Increase: 2023-06-07

[melvin-bot]

Triggered auto assignment to @JmillsExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[gadhiyamanan]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Visibility subtitle is wrong for public room

What is the root cause of that problem?

no condition added for public room description

App/src/pages/settings/Report/ReportSettingsPage.js

Lines 204 to 208 in efb1463

	<Text style={[styles.textLabelSupporting, styles.mt1]}>
	{this.props.report.visibility === CONST.REPORT.VISIBILITY.RESTRICTED
	? this.props.translate('newRoomPage.restrictedDescription')
	: this.props.translate('newRoomPage.privateDescription')}
	</Text>

What changes do you think we should make in order to solve the problem?

use {this.props.translate(`newRoomPage.${this.props.report.visibility}Description`)} instead of below condition same as WorkspaceNewRoomPage.js

App/src/pages/settings/Report/ReportSettingsPage.js

Lines 204 to 208 in efb1463

	<Text style={[styles.textLabelSupporting, styles.mt1]}>
	{this.props.report.visibility === CONST.REPORT.VISIBILITY.RESTRICTED
	? this.props.translate('newRoomPage.restrictedDescription')
	: this.props.translate('newRoomPage.privateDescription')}
	</Text>

What alternative solutions did you explore? (Optional)

None

[melvin-bot]

@JmillsExpensify Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[JmillsExpensify]

Yeah, I'm able to reproduce this one. Opening it up for proposal/reviews

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01005cb0382b9b4e71

[melvin-bot]

Current assignee @JmillsExpensify is eligible for the External assigner, not assigning anyone new.