[HOLD for payment 2023-06-29] [$1000] No consistency in margin left for green tick besides amount

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Open the app
2. Open any report
3. Send money to report
4. Click on send money message and using console window, observe margin-left to green tick icon besides amount on top and in message below
5. Again click on message displayed in that report to sent report
6. Observe margin left to tick icon in that report

Expected Result:

App should maintain consistent margin between amount and green tick throughout all the reports in the flow

Actual Result:

App maintains different margin for all the green tick instances throughout all the reports in the flow

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.22.0

Reproducible in staging?: Yes

Reproducible in production?: n/a

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

inconsistent.padding.green.tick.throughout.mp4

Recording.2913.mp4

Expensify/Expensify Issue URL:

Issue reported by: @dhanashree-sawant

Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1685201350349499

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01628393c0c27440ce
• Upwork Job ID: 1665756974338699264
• Last Price Increase: 2023-06-12

[melvin-bot]

Triggered auto assignment to @sonialiap (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[Ollyws]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The money request header checkmark and the IOU details checkmark have inconsistent margins.

What is the root cause of that problem?

The marginLeft of iouPreviewBoxCheckmark is set to 4, and moneyRequestHeaderCheckmark is set to 5.

What changes do you think we should make in order to solve the problem?

We can modify these to be the same value, 8 as requested.

To remove the checkmark from paid IOU threads we can remove the checkmark in ReportPreview.

What alternative solutions did you explore? (Optional)

[sonialiap]

Reproducible

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01628393c0c27440ce

[melvin-bot]

Current assignee @sonialiap is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @mollfpr (External)