[HOLD for payment 2023-07-06] [$1000] QR code should show for all rooms no matter the status of the room

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Go to staging dot on web chrome
2. Create a new workspace
3. Go to announce and send a message
4. Click on reply thread icon so that a new thread page opens up and send a message on the thread
5. Now delete the workspace
6. Refresh the page to see the square logo of the thread page and click on header and notice that even when it shows 'unavailable workspace', the share QR code is still shown. If the workspace is not available, it shouln't have shown the QR share code in a similar way how it gets disappeared on the announce page of the same workspace

Expected Result:

The Share QR code should be shown for all rooms no matter what their status is

Actual Result:

The Share QR code is not shown on the announce page of a deleted workspace.

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.21-2
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

chat-2023-05-29_16.20.06.mp4

Recording.827.mp4

Expensify/Expensify Issue URL:
Issue reported by: @priya-zha
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1685356464634629

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0121f15714602fea4b
• Upwork Job ID: 1667256564798566400
• Last Price Increase: 2023-06-16

[melvin-bot]

Triggered auto assignment to @abekkala (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[hungvu193]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Still able to reply in archived workspace

What is the root cause of that problem?

We are checking if the current report isArchiveRom in order to hide or show the options, but in this case the parent of the report is archived, but the children is not archived yet. That's why we still can see all these options.

App/src/pages/ReportDetailsPage.js

Line 67 in 9fa12f3

const isArchivedRoom = useMemo(() => ReportUtils.isArchivedRoom(props.report), [props.report]);

What changes do you think we should make in order to solve the problem?

We should update the logic of isArchiveRoom, if the report has parentReportID we also should to check if the report from parentReportId is already archived.

function isArchivedRoom(report) {
    if (report.parentReportID) {
        const parentReport = lodashGet(allReports, [`${ONYXKEYS.COLLECTION.REPORT}${report.parentReportID}`]);
        return lodashGet(parentReport, ['statusNum']) === CONST.REPORT.STATUS.CLOSED && lodashGet(parentReport, ['stateNum']) === CONST.REPORT.STATE_NUM.SUBMITTED;
    }
    return lodashGet(report, ['statusNum']) === CONST.REPORT.STATUS.CLOSED && lodashGet(report, ['stateNum']) === CONST.REPORT.STATE_NUM.SUBMITTED;
}

or it can be:

function isArchivedRoom(report) {
   const reportToCheck = report.parentReportID ?  lodashGet(allReports, [`${ONYXKEYS.COLLECTION.REPORT}${report.parentReportID}`]) : report;
    return lodashGet(reportToCheck, ['statusNum']) === CONST.REPORT.STATUS.CLOSED && lodashGet(reportToCheck, ['stateNum']) === CONST.REPORT.STATE_NUM.SUBMITTED;
}

Because we want to show QR code for all workspace, the we should include QR code items even when workspace is Archived.

        const items = [
            {
                key: CONST.REPORT_DETAILS_MENU_ITEM.SHARE_CODE,
                translationKey: 'common.shareCode',
                icon: Expensicons.QrCode,
                action: () => Navigation.navigate(ROUTES.getReportShareCodeRoute(props.report.reportID)),
            },
        ];

       if (isArchivedRoom) {
            return items;
        }

What alternative solutions did you explore? (Optional)

We can also calculate the report that need to be check isArchiveRoom inside ReportDetailsPage by using isThread and
report.parentReportId

const reportToCheck = report.parentReportId || isThread ? parentReport : this.props.report;
const isArchivedRoom = useMemo(() => ReportUtils.isArchivedRoom(reportToCheck), [reportToCheck]);

Result

[melvin-bot]

Triggered auto assignment to @jasperhuangg (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[abekkala]

@jasperhuangg I notice that we do note "Unavailable Workspace"

Should we not show the QR at all?

[melvin-bot]

@abekkala, @jasperhuangg Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[abekkala]

@jasperhuangg do you have a better idea on what the expectation should be.
Is the Unavailable workspace enough or should we be removing the QR all together?