[HOLD for payment 2023-06-21] [$1000] Login - "Magic code sent" below email field after go back from code input page offline

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Open https://staging.new.expensify.com/
2. Input email into email field
3. Tap "Continue"
4. Disable the internet connection
5. Click "Didn't receive a magic code?"
6. Click "Go back"
7. Enable the internet connection

Expected Result:

No messages appear in email input screen after going back online

Actual Result:

A message "Magic code sent!" appears below the email input field after going back online

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Safari
• MacOS / Desktop

Version Number: 1.3.20-1

Reproducible in staging?: Yes

Reproducible in production?: Yes

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

https://platform.applause.com/services/links/v1/external/3d4252eff76baa6e91d6bee9290541864472ccb83d454db8509a2e5b6d7b07a8

https://platform.applause.com/services/links/v1/external/fc6da469ebfd90d76b6b239a7f2a9b7c235e9e50e2d12c1a85ecaa3245110f37

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01a43ea4a6751f6484
• Upwork Job ID: 1664315741336629248
• Last Price Increase: 2023-06-01

[melvin-bot]

Triggered auto assignment to @sakluger (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[hungvu193]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Login - "Magic code sent" below email field after go back from code input page offline

What is the root cause of that problem?

We allowed to resend the magic code when it was offline, so after user pressed resend magic code and pressed back, later when user was back online, the data from server will fill the account data, which has the message inside.

App/src/pages/signin/LoginForm.js

Lines 196 to 202 in 31740a1

	{!_.isEmpty(this.props.closeAccount.success || this.props.account.message) && (
	// DotIndicatorMessage mostly expects onyxData errors, so we need to mock an object so that the messages looks similar to prop.account.errors
	<DotIndicatorMessage
	style={[styles.mv2]}
	type="success"
	messages={{0: this.props.closeAccount.success || this.props.account.message}}
	/>

What changes do you think we should make in order to solve the problem?

Since we disabled the Signin button when it's offline, it'd better to disable the Didn't receive a magic code? button when it's offline. We should also update its opacity to 50% to match the design.

 const disableStyles = this.props.network.isOffline ? styles.opacity50 : {}
    <PressableWithFeedback
        style={[styles.mt2, disableStyles]}
        onPress={this.resendValidateCode}
        underlayColor={themeColors.componentBG}
        hoverDimmingValue={1}
        pressDimmingValue={0.2}
   
        disabled={this.props.network.isOffline}
        accessibilityRole="button"
        accessibilityLabel={this.props.translate('validateCodeForm.magicCodeNotReceived')}
    >
        <Text style={[styles.link]}>{this.props.translate('validateCodeForm.magicCodeNotReceived')}</Text>
    </PressableWithFeedback>

What alternative solutions did you explore? (Optional)

N/A

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01a43ea4a6751f6484

[melvin-bot]

Current assignee @sakluger is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @sobitneupane (External)

[melvin-bot]

Triggered auto assignment to @pecanoro (External), see https://stackoverflow.com/c/expensify/questions/7972 for more details.