Login - Infinity loading is displayed for open deep link on Desktop App

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Sign out of the account
2. Enter the email on the email field and continue
3. Click on "Go Back"
4. Continue with the log in flow
5. Navigate to the email inbox and look for the magic link email
6. Right-click on the link to open it in a new Tab (change the URL to staging by adding "https://staging.new.expensify.com/")
7. Select "Open New Expensify" on the popup

Expected Result:

Verify an "Abracadabra, you are signed in!" page is displayed

Actual Result:

Infinity loading is displayed for open deep link on Desktop App. Issue occurred for all deep link on Mac/Chrome.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.20.1

Reproducible in staging?: Yes

Reproducible in production?: yes

If this was caught during regression testing, add the test name, ID and link from TestRail:
https://expensify.testrail.io/index.php?/tests/view/3478763

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

https://platform.applause.com/services/links/v1/external/3646371b71ecf433087de948eee2ba0a9e90550ccecf47f1529769c9a8c7d91f

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @Christinadobrzyn (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[ntdiary]

This seems similar to what I reported in Slack, and I also gave the RCA of this issue in its thread and another comment.

RCA:

App/web/splash/splash.js

Lines 27 to 38 in eb9df25

	const intervalId = setInterval(() => {
	passedMiliseconds += 250;
	isRootMounted = root.children.length > 0;
	if (passedMiliseconds >= minMilisecondsToWait && isRootMounted && areFontsReady) {
	clearInterval(intervalId);
	splash.style.opacity = 0;
	setTimeout(() => {
	splash.parentNode.removeChild(splash);
	}, 250);
	}
	}, 250);

In older versions, when we render the redirection screen, isRootMounted is true, and the splash screen can be automatically removed by the setInterval.
However, this logic has been deleted in the PR #17477. The splash screen can only deleted by NavigationRoot. If we still render the redirection screen (PR #19125), NavigationRoot does not exist, then users will get stuck on the splash screen.

FYI: Because PR #19819 will fundamentally fix the issue #17724 (the root causes of #19214 and #17724 are the same), I don't think we need to render the redirection screen for the verification route, then this issue will naturally go away. : )

[melvin-bot]

Looks like something related to react-navigation may have been mentioned in this issue discussion.

As a reminder, please make sure that all proposals are not workarounds and that any and all attempt to fix the issue holistically have been made before proceeding with a solution. Proposals to change our DeprecatedCustomActions.js files should not be accepted.

Feel free to drop a note in #expensify-open-source with any questions.

[Christinadobrzyn]

Might be related to - #19047 - asking

[roryabraham]

@Christinadobrzyn this appears unrelated to #19047

[Christinadobrzyn]

Hey @kbecciv I'm not able to reproduce this. Can you doublecheck this is still happening and update the steps in the Op so I can reproduce?

After I do the following steps at https://staging.new.expensify.com/

• Sign out of the account
• Enter the email on the email field and continue
• Click on "Go Back"
• Continue with the log in flow
• Navigate to the email inbox and look for the magic link email
• Right-click on the link to open it in a new Tab (change the URL to staging by adding "https://staging.new.expensify.com/")
• Select "Open New Expensify" on the popup

I get this password screen in the Desktop app

[Christinadobrzyn]

This is fixed - https://expensify.slack.com/archives/C9YU7BX5M/p1685642660059359

Closing