[$1000] Request Money: The name doesn’t update dynamically on a new workspace chat

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Go to dev on web chrome
2. Create a new workspace
3. Request money
4. First notice the workspace name on header, workspace message and the request money report
5. Now change the workspace name and notice that on the LHN and header, the workspace name gets updated dynamically. But if you see on the workspace welcome message and the request money report, the workspace name has not been updated dynamically (within the live chat)
6. Optional : Even if you refresh the page , the workplace welcome message will update the name, but still the request money report has not updated the workspace name

Expected Result:

In a new workspace chat, the changed workspace name should be updated on the welcome workspace chat message as well as on the request money report dynamically

Actual Result:

In a new workspace chat, the changed workspace name doesn't update on the welcome message as well as on the request money report

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.20.1

Reproducible in staging?: yes

Reproducible in production?: yes

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Recording.2890.mp4

error-2023-05-27_14.24.39.mp4

Expensify/Expensify Issue URL:

Issue reported by: @priya-zha

Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1685177191168879

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01402004259896cf6a
• Upwork Job ID: 1663811839421620224
• Last Price Increase: 2023-06-26

[melvin-bot]

Triggered auto assignment to @laurenreidexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[hungvu193]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The name doesn't update dynamically on the welcome message and the request money on a new workspace chat

What is the root cause of that problem?

We are using conditions here to prevent redundant updates, when a policy name is changed, there's no condition below returned true, so ReportActionsView won't trigger any update, that's why we don't see the Workspace name changed.

App/src/pages/home/report/ReportActionsView.js

Lines 122 to 173 in 2157057

	shouldComponentUpdate(nextProps, nextState) {
	if (!_.isEqual(nextProps.reportActions, this.props.reportActions)) {
	this.mostRecentIOUReportActionID = ReportActionsUtils.getMostRecentIOURequestActionID(nextProps.reportActions);
	return true;
	}
	if (lodashGet(nextProps.network, 'isOffline') !== lodashGet(this.props.network, 'isOffline')) {
	return true;
	}
	if (nextProps.report.isLoadingMoreReportActions !== this.props.report.isLoadingMoreReportActions) {
	return true;
	}
	if (nextProps.report.isLoadingReportActions !== this.props.report.isLoadingReportActions) {
	return true;
	}
	if (nextProps.report.lastReadTime !== this.props.report.lastReadTime) {
	return true;
	}
	if (nextState.isFloatingMessageCounterVisible !== this.state.isFloatingMessageCounterVisible) {
	return true;
	}
	if (nextState.newMarkerReportActionID !== this.state.newMarkerReportActionID) {
	return true;
	}
	if (this.props.isSmallScreenWidth !== nextProps.isSmallScreenWidth) {
	return true;
	}
	if (this.props.isDrawerOpen !== nextProps.isDrawerOpen) {
	return true;
	}
	if (lodashGet(this.props.report, 'hasOutstandingIOU') !== lodashGet(nextProps.report, 'hasOutstandingIOU')) {
	return true;
	}
	if (this.props.isComposerFullSize !== nextProps.isComposerFullSize) {
	return true;
	}
	if (lodashGet(this.props.report, 'statusNum') !== lodashGet(nextProps.report, 'statusNum') || lodashGet(this.props.report, 'stateNum') !== lodashGet(nextProps.report, 'stateNum')) {
	return true;
	}
	return !_.isEqual(lodashGet(this.props.report, 'icons', []), lodashGet(nextProps.report, 'icons', []));
	}

What changes do you think we should make in order to solve the problem?

Since we use the policy name in here, we also should add the check for policy value name.
In order to do that, we should pass the props polices to ReportActionsView and inside ReportActionsView's shouldComponentUpdate function, we should add more condition to check if the current policy name is updated.

// shouldComponentUpdate
const policy = this.props.policies[`${ONYXKEYS.COLLECTION.POLICY}${this.props.report.policyID}`];
const nextPolicy = nextProps.policies[`${ONYXKEYS.COLLECTION.POLICY}${nextProps.report.policyID}`];

        if (lodashGet(policy, 'name') !== lodashGet(nextPolicy, 'name')) {
            return true;
        }

The second problem is in here:

App/src/components/ReportActionItem/ReportPreview.js

Lines 118 to 121 in d8b1d84

	{props.iouReport.hasOutstandingIOU ? (
	<Text style={[styles.chatItemMessage, styles.cursorPointer, styles.colorMuted]}>
	{lodashGet(message, 'html', props.translate('iou.payerOwesAmount', {payer: managerName, amount: reportAmount}))}
	</Text>

Even the payer name is updated, we are still displaying the message from message.html, and this value is not updated.
So in here we can use directly the value from props.translate('iou.payerOwesAmount', {payer: managerName, amount: reportAmount}))

What alternative solutions did you explore? (Optional)

N/A

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01402004259896cf6a

[melvin-bot]

Current assignee @laurenreidexpensify is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @mananjadhav (External)

[melvin-bot]

Triggered auto assignment to @MonilBhavsar (External), see https://stackoverflow.com/c/expensify/questions/7972 for more details.