PAY on 06/09 [$1000] Web- Share code- “Back” tooltip appears at LHN top corner on pressing back icon

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Go to "Settings."
2. Click on " Share code."
3. Click on Chevron left symbol to go back.
4. Observe that for a fraction of seconds tooltip naming Back” appears at top left corner of the page.

Expected Result:

The “Back” tooltip should appear under the symbol only.

Actual Result:

The “Back” tooltip appears under the Chevron left symbol and at top left corner of the page.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.19.2

Reproducible in staging?: yes

Reproducible in production?: yes

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug.2.mp4

Recording.2864.mp4

Expensify/Expensify Issue URL:

Issue reported by: @usmantariq96

Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1685001326516699

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01191d973327cf8ff7
• Upwork Job ID: 1663144989463973888
• Last Price Increase: 2023-05-29

[melvin-bot]

Triggered auto assignment to @bfitzexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[huzaifa-99]

This wasn't easy to reproduce, however its visible when we quickly press the back button just as the tooltip animation starts.

1. Hover on the tooltip
2. Just as the tooltip starts to show, quickly press the back button
3. Notice tooltip is in the top left of screen

Proposal

Please re-state the problem that we are trying to solve in this issue.

We want the tooltip to wrap the child component instead of displaying on the top-left of the page and also only show when the tooltip wrap component is visible on screen

What is the root cause of that problem?

When we press the back button, the screen gets umounted, so the back button is not there anymore, however the tooltip bounds still update in Tooltip/index.js#L53-L60 with these values

{
    wrapperWidth: 0,
    wrapperHeight: 0,
    xOffset: 0,
    yOffset: 0
}

before the tooltip also unmounts. This small delay in the tooltip bounds update and unmount causes it to show in the top left for some brief ms.

What changes do you think we should make in order to solve the problem?

We should only show the tooltip when the wrapped component has some visible area on the screen. wrapperWidth and wrapperHeight indicate the wrapped component dimensions which when 0 means that wrapped component has no visible area on the screen.

In this line

App/src/components/Tooltip/index.js

Line 125 in 414dc10

{this.state.isRendered && (

we should also check if the component has some visible area on screen and then render the tooltip

{this.state.isRendered && this.state.wrapperHeight && this.state.wrapperWidth && (

Alternatively we can also check for x and y positions (0 means top left)

{this.state.isRendered && this.state.wrapperHeight && this.state.wrapperWidth && this.state.xOffset && this.state.yOffset && (

or also for height or width only

{this.state.isRendered && (this.state.wrapperHeight || this.state.wrapperWidth) && (

What alternative solutions did you explore? (Optional)

N/A

[bfitzexpensify]

Reproduced.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01191d973327cf8ff7

[melvin-bot]

Current assignee @bfitzexpensify is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @sobitneupane (External)