[Awaiting C+ Payment confirmation] [HOLD for payment 2023-08-21] [$1000] Inconsistent file error result on uploading unsupported file type

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Open staging.new.expensify.com
2. Send a .exe file to a chat
3. Send a .tar.gz file to a chat

Expected Result:

Both should have consistent unsupported file type error

Actual Result:

While trying to attach .exe file returned error dialog immediately, trying to attach .tar.gz file doesn't returned the same dialog error and returned the error on sending the message instead

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.19-2
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Inconsistent.File.Filter.mp4

Recording.785.mp4

Expensify/Expensify Issue URL:
Issue reported by: @kerupuksambel
Slack conversation:
https://expensify.slack.com/archives/C049HHMV9SM/p1684986305893649
View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~018f83b776223928ef
• Upwork Job ID: 1663615039149555712
• Last Price Increase: 2023-06-06

[melvin-bot]

Triggered auto assignment to @trjExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[PrashantMangukiya]

Proposal

Posting proposal early as per new guidelines

Please re-state the problem that we are trying to solve in this issue.

Inconsistent file error result on uploading unsupported file type

What is the root cause of that problem?

Not allowed file type checking done via variable from const file here

App/src/CONST.js

Lines 41 to 95 in 12d2f3c

	UNALLOWED_EXTENSIONS: [
	'ade',
	'adp',
	'apk',
	'appx',
	'appxbundle',
	'bat',
	'cab',
	'chm',
	'cmd',
	'com',
	'cpl',
	'diagcab',
	'diagcfg',
	'diagpack',
	'dll',
	'dmg',
	'ex',
	'ex_',
	'exe',
	'hta',
	'img',
	'ins',
	'iso',
	'isp',
	'jar',
	'jnlp',
	'js',
	'jse',
	'lib',
	'lnk',
	'mde',
	'msc',
	'msi',
	'msix',
	'msixbundle',
	'msp',
	'mst',
	'nsh',
	'pif',
	'ps1',
	'scr',
	'sct',
	'shb',
	'sys',
	'vb',
	'vbe',
	'vbs',
	'vhd',
	'vxd',
	'wsc',
	'wsf',
	'wsh',
	'xll',
	],

We can see gz extension not added in this. So it will not show error while file selected with gz extension. This is the root cause of the problem.

What changes do you think we should make in order to solve the problem?

We have to add gz extension within UNALLOWED_EXTENSIONS array as shown under. It will solve the issue.

UNALLOWED_EXTENSIONS: [ 
   ...
  'exe',
  'gz',    // *** Add this
  'hta',
   ...
]

What alternative solutions did you explore? (Optional)

None

Result

19718-Unallowed.mov

[trjExpensify]

Yeah, seems clear to me. Though, @Beamanator are we just going to keep running into this maintaining a list of "unallowed filetypes" versus a list of allowed ones and then throwing the front-end error if it's not one of them? 😕

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~018f83b776223928ef

[melvin-bot]

Current assignee @trjExpensify is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @sobitneupane (External)