[HOLD for payment 2023-06-29] [$2000] Web - Login - 2FA Input field not focused when proceed from magic code page

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

Precondition - User has setup a 2FA to log into account

1. Open https://staging.new.expensify.com/

2. Input email for account from the precondition

3. Click "Continue"
   4.Input magic code

4. Click "Continue"

5. Press digits in the keyboard

Expected Result:

After user proceeds to authenticator code input page - the input field is focused and user can instantly type the code

Actual Result:

After user proceeds to authenticator code input page - the input field is NOT focused and user has to additionally click on it to set focus

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.19-2
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Bug6069872_Recording__606.mp4

Expensify/Expensify Issue URL:
Issue reported by: Applause internal team
Slack conversation:

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0145b8fd18db4b7dff
• Upwork Job ID: 1663365147022503936
• Last Price Increase: 2023-06-14

[melvin-bot]

Triggered auto assignment to @kadiealexander (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[PrashantMangukiya]

Proposal

Posting proposal early as per new guidelines

Please re-state the problem that we are trying to solve in this issue.

Web - Login - 2FA Input field not focused when proceed from magic code page

What is the root cause of that problem?

We are rendering magic code and 2FA input conditionally via code block shown below.

App/src/pages/signin/ValidateCodeForm/BaseValidateCodeForm.js

Lines 198 to 242 in 12d2f3c

	{this.props.account.requiresTwoFactorAuth ? (
	<View style={[styles.mv3]}>
	<MagicCodeInput
	autoComplete={this.props.autoComplete}
	ref={(el) => (this.input2FA = el)}
	label={this.props.translate('common.twoFactorCode')}
	name="twoFactorAuthCode"
	value={this.state.twoFactorAuthCode}
	onChangeText={(text) => this.onTextInput(text, 'twoFactorAuthCode')}
	onFulfill={this.validateAndSubmitForm}
	maxLength={CONST.TFA_CODE_LENGTH}
	errorText={this.state.formError.twoFactorAuthCode ? this.props.translate(this.state.formError.twoFactorAuthCode) : ''}
	hasError={hasError}
	autoFocus
	/>
	</View>
	) : (
	<View style={[styles.mv3]}>
	<MagicCodeInput
	autoComplete={this.props.autoComplete}
	ref={(el) => (this.inputValidateCode = el)}
	label={this.props.translate('common.magicCode')}
	name="validateCode"
	value={this.state.validateCode}
	onChangeText={(text) => this.onTextInput(text, 'validateCode')}
	onFulfill={this.validateAndSubmitForm}
	errorText={this.state.formError.validateCode ? this.props.translate(this.state.formError.validateCode) : ''}
	hasError={hasError}
	autoFocus
	/>
	<View style={[styles.changeExpensifyLoginLinkContainer]}>
	{this.state.linkSent ? (
	<Text style={[styles.mt2]}>{this.props.account.message ? this.props.translate(this.props.account.message) : ''}</Text>
	) : (
	<TouchableOpacity
	style={[styles.mt2]}
	onPress={this.resendValidateCode}
	underlayColor={themeColors.componentBG}
	>
	<Text style={[styles.link]}>{this.props.translate('validateCodeForm.magicCodeNotReceived')}</Text>
	</TouchableOpacity>
	)}
	</View>
	</View>
	)}

We can see there is autofocus set at line 211 and 226 although it only focus during magic code input but not during 2FA inout.

So here problem that we are rendering same component conditionally within same parent, so here react will just pass the new props and keep the component loaded. So component did mount will not trigger when 2FA input appear. This is the root cause of the problem.

What changes do you think we should make in order to solve the problem?

We have to pass unique key prop to <MagicCodeInput> component render at line 200 and 216 as shown code below.

{this.props.account.requiresTwoFactorAuth ? ( 
     <View style={[styles.mv3]}> 
         <MagicCodeInput 
             ...
            key="2FAInput"  // *** Add this prop ***
         /> 
     </View> 
 ) : ( 
     <View style={[styles.mv3]}> 
         <MagicCodeInput 
             ...
            key="magicCodeInput"   // *** Add this prop ***
         /> 
         <View style={[styles.changeExpensifyLoginLinkContainer]}> 
            ...
         </View> 
     </View> 
 )} 

So react will treat both component different and it will mount component from scratch instead of just passing the new props. This will solve the issue as shown in result video.

Note: At present I set key for both component for sample purpose, we can decide key as suggested by engineering team.

What alternative solutions did you explore? (Optional)

None

Result

19711-2FA-AutoFocus.mp4

[kadiealexander]

Reproduced on staging web!

2023-05-30_14-01-08.mp4

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~0145b8fd18db4b7dff

[melvin-bot]

Current assignee @kadiealexander is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @abdulrahuman5196 (External)