[$1000] Chat - Welcome message from admin instead of Concierge

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Issue found when executing #18662

Action Performed:

1. Login to NewDot
2. Create a WS and add user B
3. As user A create a public room and add a welcome message
4. As user B accept invitation to the room (enter the room)

Expected Result:

Welcome message should be from Concierge

Actual Result:

Welcome message is displayed from admin

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.19.1

Reproducible in staging?: yes

Reproducible in production?: no

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

https://platform.applause.com/services/links/v1/external/f08dd9a05654742690178669b51eba43053026de2a0c4a1b9de9b93a14fbbdbf

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~017ada3b1b1cf50c9d
• Upwork Job ID: 1664729277484212224
• Last Price Increase: 2023-06-02

[melvin-bot]

Triggered auto assignment to @mallenexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

@mallenexpensify Whoops! This issue is 2 days overdue. Let's get this updated quick!

[mallenexpensify]

@kbecciv when I click on Details > Members I don't see an option to add a member, how do I

As a user A invite user B to public room

[kbecciv]

Hello @mallenexpensify! Let me correct the steps, you need to invite user first by going to Workspace and Invite user and than create a public room. Sending you full video for linked PR. Please let me know if you have any question and I will be happy to help.

Recording.2848.mp4

[StevenKKC]

Proposal

Please re-state the problem that we are trying to solve in this issue.

In the public room, welcome message is displayed from admin, instead of from Concierge.

What is the root cause of that problem?

Welcome message is created by admin, and when display welcome message, display the message's actorEmail, so message is displayed from admin.

App/src/pages/home/report/ReportActionItemSingle.js

Lines 69 to 71 in af6fb07

	const actorEmail = props.action.actorEmail.replace(CONST.REGEX.MERGED_ACCOUNT_PREFIX, '');
	const {avatar, displayName, pendingFields} = props.personalDetails[actorEmail] || {};
	const avatarSource = UserUtils.getAvatar(avatar, actorEmail);

What changes do you think we should make in order to solve the problem?

When display welcome message, we should change the above code in order to display Concierge's avatar and name.

    const whisperedToAccountIDs = lodashGet(props.action, 'whisperedToAccountIDs', []);
    const isWhisper = whisperedToAccountIDs.length > 0;
    const actorEmail = (isWhisper && ReportUtils.isPublicRoom(props.report)) ? CONST.EMAIL.CONCIERGE : props.action.actorEmail.replace(CONST.REGEX.MERGED_ACCOUNT_PREFIX, '');
    const {avatar, displayName, pendingFields} = props.personalDetails[actorEmail] || {};
    const avatarSource = UserUtils.getAvatar(avatar, actorEmail);

If the report action contains the welcome message, the whisperedToAccountIDs fields is set to the login user id, and we should check this field.

One thing to pay attention is that welcome message may be displayed as a group. This happens when the admin already adds comment before invited user join the public room. In this case, the welcome message is displayed with the comment as a group, so the Concierge's avatar and name does not display.

App/src/pages/home/report/ReportActionItem.js

Lines 375 to 390 in af6fb07

	if (!props.displayAsGroup) {
	return (
	<ReportActionItemSingle
	action={props.action}
	showHeader={!props.draftMessage}
	wrapperStyles={[styles.chatItem, isWhisper ? styles.pt1 : {}]}
	shouldShowSubscriptAvatar={props.shouldShowSubscriptAvatar}
	report={props.report}
	hasBeenFlagged={!_.contains([CONST.MODERATION.MODERATOR_DECISION_APPROVED, CONST.MODERATION.MODERATOR_DECISION_PENDING], moderationDecision)}
	>
	{content}
	</ReportActionItemSingle>
	);
	}
	return <ReportActionItemGrouped wrapperStyles={[styles.chatItem, isWhisper ? styles.pt1 : {}]}>{content}</ReportActionItemGrouped>;

We should change the above if condition as below.

        if (!props.displayAsGroup || isWhisper) {

What alternative solutions did you explore? (Optional)

None

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~017ada3b1b1cf50c9d