[PAID] [$1000] New Room - App crashes if create room offline and change Welcome message

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Issue found when executing PR #18662

Action Performed:

1. Login to NewDot
2. Go offline
3. Create a public room
4. Go to room settings and try to change Welcome message

Expected Result:

Welcome message can be changed

Actual Result:

App crashes

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.19.2

Reproducible in staging?: Yes

Reproducible in production?: No

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

https://platform.applause.com/services/links/v1/external/59527d73ce682e3813444e740078eb12b099af3a21b38e501290ee2a70d0da93

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01fc39914f0ea0ccf3
• Upwork Job ID: 1663259031809458176
• Last Price Increase: 2023-05-29

[melvin-bot]

Triggered auto assignment to @strepanier03 (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[dukenv0307]

Proposal

Please re-state the problem that we are trying to solve in this issue.

New Room - App crashes if create room offline and change Welcome message

What is the root cause of that problem?

When creating new room offline, there is no welcomeMessage field in created report on ONYX

App/src/pages/ReportWelcomeMessagePage.js

Line 39 in 06192ac

const [welcomeMessage, setWelcomeMessage] = useState(parser.htmlToMarkdown(props.report.welcomeMessage));

So props.report.welcomeMessage will be undefined.
It caused a crash app because parser.htmlToMarkdown function receive a string param

What changes do you think we should make in order to solve the problem?

We should use lodash get to get welcomeMessage like this

    const [welcomeMessage, setWelcomeMessage] = useState(parser.htmlToMarkdown(lodashGet(props.report, ['welcomeMessage'], '')));

What alternative solutions did you explore? (Optional)

[hungvu193]

Proposal

Please re-state the problem that we are trying to solve in this issue.

New Room - App crashes if create room offline and change Welcome message

What is the root cause of that problem?

While creating the public room in offline mode, we save the optimistic data to the Onyx first, but our optimistic data didn't include the welcomeMessage, so after that you went to Setting => Welcome Message Page, app will crashed because of this line:

App/src/pages/ReportWelcomeMessagePage.js

Line 39 in 7bf0763

const [welcomeMessage, setWelcomeMessage] = useState(parser.htmlToMarkdown(props.report.welcomeMessage));

Because htmlToMarkdown function expected a string as param:

    htmlToMarkdown(htmlString) {
        let generatedMarkdown = htmlString;
        const body = /<(body)(?:"[^"]*"|'[^']*'|[^'"><])*>(?:\n|\r\n)?([\s\S]*?)(?:\n|\r\n)?<\/\1>(?![^<]*(<\/pre>|<\/code>))/im;
        const parseBodyTag = generatedMarkdown.match(body);

        // If body tag is found then use the content of body rather than the whole HTML
        if (parseBodyTag) {
            generatedMarkdown = parseBodyTag[2];
        }

What changes do you think we should make in order to solve the problem?

Since we added initial value for other params while creating a report, that will be better if we could also add a initialValue for welcomeMessage. We should update function buildOptimisticChatReport to include the welcomeMessage with a initial value.

function buildOptimisticChatReport(
    participantList,
    reportName = CONST.REPORT.DEFAULT_REPORT_NAME,
    chatType = '',
    policyID = CONST.POLICY.OWNER_EMAIL_FAKE,
    ownerEmail = CONST.REPORT.OWNER_EMAIL_FAKE,
    isOwnPolicyExpenseChat = false,
    oldPolicyName = '',
    visibility = undefined,
    notificationPreference = CONST.REPORT.NOTIFICATION_PREFERENCE.ALWAYS,
    parentReportActionID = '',
    parentReportID = '',
    welcomeMessage = '',
) {
return {
....,
welcomeMessage
}

In case we only want add welcomeMessage for specific report (like policyRoom), we can add more condition in the return to do that.

What alternative solutions did you explore? (Optional)

N/A

Result

Screen.Recording.2023-05-29.at.18.35.07.mov

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01fc39914f0ea0ccf3

[melvin-bot]

Triggered auto assignment to @michaelhaxhiu (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.