[HOLD for payment 2023-06-13] [$1000] Pressing enter key on the Description page adds the user to the Who was There page.

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Open App
2. Press FAB > New group > add more than two users > Press Create group
3. Go to the created group
4. Press + from composer > Split bill > Add amount > deselect one or two users from Who was there? list.
5. Press Description and add description and press enter
6. Observe the Who was there? list

Expected Result:

Pressing enter on the Description page should not have to select the user on Who was there? list.

Actual Result:

Pressing enter on the Description page is adding a user to Who was there? list.

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.17.0
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

split-bill-on-press.mov

Recording.726.mp4

Expensify/Expensify Issue URL:
Issue reported by: @jayeshmangwani
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1684511132545629

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01ea1ea807e254fd18
• Upwork Job ID: 1661337679625768960
• Last Price Increase: 2023-05-24

[melvin-bot]

Triggered auto assignment to @sonialiap (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[kavimuru]

Proposal by @jayeshmangwani

Proposal

Please re-state the problem that we are trying to solve in this issue.

Pressing enter key on the Description page adds the user to the Who was There list

What is the root cause of that problem?

Issue is happening because we have a listener on the BaseOptionsSelector component that listens enter(enterConfig.shortcutKey) key press,

App/src/components/OptionsSelector/BaseOptionsSelector.js

Lines 56 to 58 in 9e43cb7

	this.unsubscribeEnter = KeyboardShortcut.subscribe(
	enterConfig.shortcutKey,
	() => {

And when we navigate to the next screen then BaseOptionsSelector is not focused and it still listens to the enter press event

What changes do you think we should make in order to solve the problem?

On BaseOptionsSelector Component we need to add withNavigationFocus and then here on lister unsubscribeEnter we need to add a condition that if screen is not focused then do nothing and return early

App/src/components/OptionsSelector/BaseOptionsSelector.js

Lines 60 to 62 in 9e43cb7

	if (!focusedOption) {
	return;
	}

need to adjust conditions like this
if (!focusedOption || !this.props.isFocused)
note: This same issue is happening at the Workspace member page, Go to any workspace > Manage members > Invite > Select few users > Press Next then on Add message page press enter It will add 1 extra user than you have selected

What alternative solutions did you explore? (Optional)

none

[melvin-bot]

Looks like something related to react-navigation may have been mentioned in this issue discussion.

As a reminder, please make sure that all proposals are not workarounds and that any and all attempt to fix the issue holistically have been made before proceeding with a solution. Proposals to change our DeprecatedCustomActions.js files should not be accepted.

Feel free to drop a note in #expensify-open-source with any questions.

[jayeshmangwani]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Pressing enter key on the Description page adds the user to the Who was There list

What is the root cause of that problem?

Issue is happening because we have a listener on the BaseOptionsSelector component that listens enter(enterConfig.shortcutKey) key press,

App/src/components/OptionsSelector/BaseOptionsSelector.js

Lines 56 to 58 in 9e43cb7

	this.unsubscribeEnter = KeyboardShortcut.subscribe(
	enterConfig.shortcutKey,
	() => {

And when we navigate to the next screen then BaseOptionsSelector is not focused and it still listens to the enter press event

What changes do you think we should make in order to solve the problem?

On BaseOptionsSelector Component we need to add withNavigationFocus and then here on lister unsubscribeEnter we need to add a condition that if screen is not focused then do nothing and return early

App/src/components/OptionsSelector/BaseOptionsSelector.js

Lines 60 to 62 in 9e43cb7

	if (!focusedOption) {
	return;
	}

need to adjust conditions like this

if (!focusedOption || !this.props.isFocused)

note: This same issue is happening at the Workspace member page, Go to any workspace > Manage members > Invite > Select few users > Press Next then on Add message page press enter It will add 1 extra user than you have selected

Result

solved-on-press-bug.mov

What alternative solutions did you explore? (Optional)

none

[sonialiap]

Reproducible 👍

I found that pressing return/enter checks the box on one previously unchecked user in the who was there list. But if I click save, user is not added

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01ea1ea807e254fd18

[melvin-bot]

Current assignee @sonialiap is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @Santhosh-Sellavel (External)