[$1000] Phone number is displayed incorrect in mention list

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Open any chat
2. Make sure that you just had a chat with an account is created by phone
3. Enter @expensify.sms
4. See that the phone number is displayed in mention list. But there are no highlight

Expected Result:

Should display highlight if It matchs

Actual Result:

there are no highlight

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.16.5
Reproducible in staging?:
Reproducible in production?:
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Expensify/Expensify Issue URL:
Issue reported by: @dukenv0307
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1684318419304349

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01873d11c7bbaa826a
• Upwork Job ID: 1659905410838413312
• Last Price Increase: 2023-05-27

[melvin-bot]

Triggered auto assignment to @NicMendonca (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[kavimuru]

Proposal by @dukenv0307

Proposal

Please re-state the problem that we are trying to solve in this issue.

Phone number is displayed incorrect in mention list

What is the root cause of that problem?

App/src/components/MentionSuggestions.js

Line 66 in 811c0f3

const displayedText = _.uniq([item.text, item.alternateText]).join(' - ');

We combine text and alternateText to display in mentioned list. But with a phone number the text and alternate text are the same
<img width=“338” alt=“Screenshot 2023-05-17 at 17 20 03" src=“https://github.com/Expensify/App/assets/129500732/0eb59b98-907a-4ad7-aa17-4a39b66e02f6”>

What changes do you think we should make in order to solve the problem?

We should use login field instead of alternateText. With my solution, It still works well with email

Results

<img width=“873" alt=“Screenshot 2023-05-17 at 17 23 43” src=“https://github.com/Expensify/App/assets/129500732/65e171c2-67a9-4ad7-98a9-deb7d15e804a”>

[dukenv0307]

I post again because photo not showing in the above proposal from @kavimuru

Proposal

Please re-state the problem that we are trying to solve in this issue.

Phone number is displayed incorrect in mention list

What is the root cause of that problem?

App/src/components/MentionSuggestions.js

Line 66 in 811c0f3

const displayedText = _.uniq([item.text, item.alternateText]).join(' - ');

We combine text and alternateText to display in mentioned list. But with a phone number the text and alternate text are the same
https://github-production-user-asset-6210df.s3.amazonaws.com/129500732/238914433-0eb59b98-907a-4ad7-aa17-4a39b66e02f6.png

What changes do you think we should make in order to solve the problem?

We should use login field instead of alternateText. With my solution, It still works well with email

Results

<img width=“873" alt=“Screenshot 2023-05-17 at 17 23 43” src=“https://github.com/Expensify/App/assets/129500732/65e171c2-67a9-4ad7-98a9-deb7d15e804a”>

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01873d11c7bbaa826a

[melvin-bot]

Current assignee @NicMendonca is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @aimane-chnaif (External)