Settings- Security - Invalid code error persists if close and reopen 2-factor setup

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Issue found when executing #18576

Action Performed:

1. Open Expensify Desktop app
2. Click on profile icon
3. Click on "Security"
4. Click on "Two-factor authentication"
5. Click on copy codes / Download
6. Save the codes if needed
7. Click on "Next"
8. Input incorrect code
9. Click on "X"
10. Repeat steps 2-6

Expected Result:

When user re-opens 2-factor auth setup after entering an incorrect code at the previous try - the error about invalid code is no longer displayed

Actual Result:

When user re-opens 2-factor auth setup after entering an incorrect code at the previous try - the error about invalid code is STILL displayed

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.16.3

Reproducible in staging?: yes

Reproducible in production?: New feature

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

https://platform.applause.com/services/links/v1/external/2a7d18fefa82002513ff35352fa067ef1091f0d748fc784ee06d58b6d5289574

https://platform.applause.com/services/links/v1/external/203f0ffa6c939638434b9997c064fac9ac6f30028986123e096bbcfaedb3a18d

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @sonialiap (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[Pujan92]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Invalid error code persists for 2-factor setup page when we reopen it

What is the root cause of that problem?

We are not cleaning the account messages from onyx once we unmount the BaseTwoFactorAuthForm component.

What changes do you think we should make in order to solve the problem?

We need to add the useEffect cleanup function for BaseTwoFactorAuthForm component where we will call the function Session.clearAccountMessages(); which gets executed on the unmount of the component.

Result

Screen.Recording.2023-05-19.at.2.30.27.AM.mp4

[melvin-bot]

@sonialiap Whoops! This issue is 2 days overdue. Let's get this updated quick!

[MonilBhavsar]

Dupe of #19187