[HOLD for payment 2023-06-05] [$1000] Disabled cursor is being shown instead of default cursor

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Open the app and keep the screen size below 800px
2. Navigate to Settings > Payments > Have Paypal as a payment method
3. Click on the Paypal account
4. Hover over Paypal.me and username
5. You'll notice cursor is disabled

Expected Result:

Default cursor should be shown

Actual Result:

Disabled cursor is being shown

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.16-3
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Screen.Recording.2023-05-16.at.8.09.18.PM.mov

Recording.645.mp4

Expensify/Expensify Issue URL:
Issue reported by: @daraksha-dk
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1684248402352109

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01e327fcf150738b2d
• Upwork Job ID: 1659343886988689408
• Last Price Increase: 2023-05-18

[melvin-bot]

Triggered auto assignment to @slafortune (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[kavimuru]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Wrong cursor styling for read-only MenuItem

What is the root cause of that problem?

The root cause of this issue is that we are using disabled={true} with interactive={false} to make a read-only MenuItem. Which adds the extra disabled styles to the component.

What changes do you think we should make in order to solve the problem?

To fix this, we first need to decide what type of styling is needed when:

• disabled and interactive are true
• disabled is true and interactive is false
• disabled is undefined/false and interactive is false

My suggestion:

(keeping interactive true by default)

• When interactive is true & disabled is false/undefined => default state with cursor pointer
• When both disabled & interactive are true => apply disabled styles like cursor disabled (normal scenario for disabled state)
• When both disabled & interactive are false => Use the default cursor styling. (when data is read-only like Title)
• When interactive is false & disabled is true => Add a different type of disabled styling like an opacity change (optional)
  These changes will be needed to be done in src/components/MenuItem.js and after making these changes other places where it's being used will need to be updated accordingly.
  by @daraksha-dk

[daraksha-dk]

Proposal

#19208 (comment)

I'd like to add the location for this particular instance where disabled prop is being used:

• App/src/pages/settings/Payments/PaymentsPage/BasePaymentsPage.js

  Lines 440 to 445 in cb6ba23

  	icon={this.state.formattedSelectedPaymentMethod.icon}
  	description={this.state.formattedSelectedPaymentMethod.description}
  	wrapperStyle={[styles.pv0, styles.ph0, styles.mb4]}
  	disabled
  	interactive={false}
  	/>

And like I've mentioned in my proposal above, I'll be cleaning up rest of the app as well once the expected behaviour is decided

after making these changes other places where it's being used will need to be updated accordingly.

[kushu7]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Disabled cursor is being shown instead of default cursor

What is the root cause of that problem?

Its happening because We are using MenuItem here with disabled=true. its adding cursor disabled.

What changes do you think we should make in order to solve the problem?

App/src/pages/settings/Payments/PaymentsPage/BasePaymentsPage.js

Lines 438 to 445 in 7d7fa72

	<MenuItem
	title={this.state.formattedSelectedPaymentMethod.title || ''}
	icon={this.state.formattedSelectedPaymentMethod.icon}
	description={this.state.formattedSelectedPaymentMethod.description}
	wrapperStyle={[styles.pv0, styles.ph0, styles.mb4]}
	disabled
	interactive={false}
	/>

we can set disabled= false. it will make cursor pointer. then we can ovveride it by
adding styles.cursorDefault to wrapperStyle array

What alternative solutions did you explore? (Optional)

None

Result:

Screen.Recording.2023-05-19.at.1.13.54.AM.mov

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01e327fcf150738b2d

[melvin-bot]

Triggered auto assignment to @miljakljajic (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @thesahindia (External)