[HOLD for payment 2023-06-02] [$1000] Green icon on the left of share code is not turning white like others when hovered.

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Open "Settings".
2. Hover on share code option.

Expected Result:

Icon on the left of share code should turn white like others when hovered.

Actual Result:

Green icon on the left of share code is not turning white like others when hovered.

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.14-9
Reproducible in staging?: y
Reproducible in production?:
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

2.1.mp4

Expensify/Expensify Issue URL:
Issue reported by: @usmantariq96
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1684166606971679

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01e7e23eb0ca73f31d
• Upwork Job ID: 1659497347649708032
• Last Price Increase: 2023-05-19

[melvin-bot]

Triggered auto assignment to @zanyrenney (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[ahmedGaber93]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Green icon on the left of share code is not turning white like others when hovered.

What is the root cause of that problem?

The svg code of icon qrcode.svg has path as chlidren with inline fill color green, so when user hovers the icon, and change it's fill color, the new color is applied to parent SVG but the child path still with green color.

App/assets/images/qrcode.svg

Lines 1 to 5 in 811c0f3

	<svg width="20" height="20" viewBox="0 0 15 14" fill="none" xmlns="http://www.w3.org/2000/svg">
	<path
	d="M0.666504 6H6.6665V0H0.666504V6ZM2.6665 2H4.6665V4H2.6665V2ZM8.6665 0V6H14.6665V0H8.6665ZM12.6665 4H10.6665V2H12.6665V4ZM0.666504 14H6.6665V8H0.666504V14ZM2.6665 10H4.6665V12H2.6665V10ZM13.6665 8H14.6665V12H11.6665V11H10.6665V14H8.6665V8H11.6665V9H13.6665V8ZM13.6665 13H14.6665V14H13.6665V13ZM11.6665 13H12.6665V14H11.6665V13Z"
	fill="#03D47C" />
	</svg>

What changes do you think we should make in order to solve the problem?

remove fill="#03D47C" from the child path here, and when the user hovers the icon, the parent SVG color with change and this path will inherit the new color.

App/assets/images/qrcode.svg

Line 4 in 811c0f3

fill="#03D47C" />

Result

Screen.Recording.2023-05-17.at.1.18.22.AM.mov

What alternative solutions did you explore? (Optional)

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01e7e23eb0ca73f31d

[melvin-bot]

Current assignee @zanyrenney is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @sobitneupane (External)