[HOLD for payment 2023-06-02] Web - Login - User gets 'Magic Code' instead of 'Abracadabra, you are signed in' message

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

First scenario:

1. Open staging.new.expensify.com and continue with the log in flow with any account
2. Navigate to the email inbox and look for the magic link email
3. Change the link to staging if needed
4. Open a new tab and paste the link in the URL
5. Verify an "Abracadabra, you are signed in!" page is displayed

Second scenario

1. Log out of NewDot and request a new magic link
2. Navigate to email and locate the magic link - change to staging if needed
3. Open an new tab and navigate to the staging link
4. Verify the 2FA required page is displayed. Should have a message similar to "Please enter the two-factor authentication code where you are trying to sign in."
5. Navigate back to the original tab - Keep the second tab open
6. Verify the log in flow is now asking the user to enter the 2FA code
7. Enter the 2FA code
8. Verify the user can log in
9. Navigate to the secondary tab
10. Verify the "Abracadabra, you're logged in" page is displayed

Expected Result:

"Abracadabra, you are signed in!" page is displayed.

Actual Result:

User gets 'Magic Code' instead of 'Abracadabra, you are signed in' message

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.14.9

Reproducible in staging?: Yes

Reproducible in production?: No

If this was caught during regression testing, add the test name, ID and link from TestRail:
First scenario https://expensify.testrail.io/index.php?/tests/view/3456321
Second scenario https://expensify.testrail.io/index.php?/tests/view/3456319

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

20230516-1424-44.1852894.mp4

Recording.2715.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

[kbecciv]

@isagoico GH created for two TCs

[OSBotify]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @roryabraham (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[isagoico]

There's a weird behavior on Staging surrounding the Magic link. A few hours ago this was working without issues, video below:

20230516-1422-35.9589889.mp4

Now, the "abracadabra" page is not being displayed consistently on staging nor production. Will investigate further on the issue🫠 @roryabraham I think that we should be good with removing the deploy blocker label on this one.

[yuwenmemon]

Not a blocker for the NewDot deploy since this is also happening on Prod.