[HOLD for payment 2023-06-13] [$1000] On task description editing page field is showing mandatory when editing an existing task where by actually field should be optional

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Launch the app -> Login in account
2. Click on FAB button -> Click on Assign task option
3. Enter title & description -> add any assignee -> Click on confirm task -> will navigate to task detail page
4. On task detail page click on Description -> clear title field and press save -> Notice error message is This field is required instead of please enter a title

Expected Result:

On task description editing page field should be optional user can remove description & can save

Actual Result:

On task description editing page field is mandatory & user can't remove values

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.14.9
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Expensify/Expensify Issue URL:
Issue reported by: @dhairyasenjaliya
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1684138155046919

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0136c1b2820ecd2721
• Upwork Job ID: 1658850991367442432
• Last Price Increase: 2023-05-17

[melvin-bot]

Triggered auto assignment to @zanyrenney (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[kavimuru]

Proposal

by
@Dhairya Senjaliya

Please re-state the problem that we are trying to solve in this issue.

• On task description editing page field is showing mandatory where by actually field is optional

What is the root cause of that problem?

The reason is we are validating on validate() Form to check if field is empty then throws the error message

What changes do you think we should make in order to solve the problem?

We need to remove _.isEmpty(values.description validation from validate() function
And also on Task-actions we have one more condition where by if we have blank values on form then we are replacing it with old description name which we need to remove

// Change 1
// TaskDescriptionPage.js
-  const validate = useCallback(
-    (values) => {
-      const errors = {};
-      if (_.isEmpty(values.description)) {
-        errors.description = props.translate('common.error.fieldRequired');
-      }
-      return errors;
-    },
-    [props],
-  );
+.  const validate = useCallback(() => ({}), []);
          <TextInput
            inputID="description"
            name="description"
-           label={props.translate('newTaskPage.description')}
+           label={props.translate('newTaskPage.descriptionOptional')}
            defaultValue={(props.task.report && props.task.report.description) || ''}
            ref={(el) => (inputRef.current = el)}
          />
// Change 2
```diff
// libs/actions/Task.js
On editTaskAndNavigate()
 const optimisticData = [
    {
      onyxMethod: Onyx.METHOD.MERGE,
      key: `${ONYXKEYS.COLLECTION.REPORT_ACTIONS}${report.reportID}`,
      value: {[editTaskReportAction.reportActionID]: editTaskReportAction},
    },
    {
      onyxMethod: Onyx.METHOD.MERGE,
      key: `${ONYXKEYS.COLLECTION.REPORT}${report.reportID}`,
      value: {
        reportName,
-		description: description || report.description,
+       description,
      	assignee: assignee || report.assignee,
      },
    },
 ];
// Optional change
  API.write(
    'EditTask',
    {
      taskReportID: report.reportID,
      title: reportName,
-      description: description || report.description,
+      description: description,
      assignee: assignee || report.assignee,
      editedTaskReportActionID: editTaskReportAction.reportActionID,
      assigneeChatReportActionID: optimisticAssigneeAddComment ? optimisticAssigneeAddComment.reportAction.reportActionID : 0,
    },
    {optimisticData, successData, failureData},
  );

What alternative solutions did you explore? (Optional)

• N/A

[zanyrenney]

This is not reproducible so I expect that it has been resolved in a recent deploy:

Testing task - description not required

• no RBR
• no error message
• task is able to be sent without description

[zanyrenney]

commented in slack -- https://expensify.slack.com/archives/C049HHMV9SM/p1684334268630209?thread_ts=1684138155.046919&cid=C049HHMV9SM

[zanyrenney]

checking here in slack too about version numbers : https://expensify.slack.com/archives/C01SKUP7QR0/p1684334987930659

[zanyrenney]

Okay, did some more testing and I understand the bug better now. It's that when you edit an existing task description, it is showing the error, not that the description field always throws an error.

[zanyrenney]

Repro:

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~0136c1b2820ecd2721