[HOLD for payment 2023-06-12] [$1000] Mentions results are displayed with half height on click of add attachment

[mvtglobally]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Open the app
2. Open any report
3. Write @ to open mention results
4. Click on plus and click 'add attachment' and observe that mention results close and reopen to display in half the height for few seconds untill attachment selection window is not open

Expected Result:

App should not display mention results on add attachment as it does not for emoji suggestions

Actual Result:

App displays mention results in half the height on add attachment click

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

**Version Number:**1.3.13-4
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Recording.601.mp4

half.height.mention.results.glitch.mp4

Expensify/Expensify Issue URL:
Issue reported by: @dhanashree-sawant
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1684069576237329

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~016704c5d525d79faa
• Upwork Job ID: 1658817764217602048
• Last Price Increase: 2023-05-17

[melvin-bot]

Triggered auto assignment to @anmurali (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[therealsujitk]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Mention suggestions list flickers while the file picker is being opened for adding attachments.

What is the root cause of that problem?

The reason for this is the ReportActionCompose (text field) gets refocused after the Add attachment link has been clicked. This doesn't happen in the case of the emoji suggestion list because that case has been taken care of explicitly.

What changes do you think we should make in order to solve the problem?

In the code shown below (Line 982), we explicitly block the emoji suggestions list from being opened if the file picker is opened using the shouldBlockEmojiCalc state variable.

App/src/pages/home/report/ReportActionCompose.js

Lines 978 to 988 in dd5fbb6

	onSelected: () => {
	// Set a flag to block emoji calculation until we're finished using the file picker,
	// which will stop any flickering as the file picker opens on non-native devices.
	if (this.willBlurTextInputOnTapOutside) {
	this.setState({shouldBlockEmojiCalc: true});
	}
	openPicker({
	onPicked: displayFileInModal,
	});
	},

Similarly this has to be done for the mention suggestions list using a shouldBlockMentionCalc state variable.

What alternative solutions did you explore? (Optional)

None.

[dukenv0307]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Mention results flickers while opened the add attachments.

What is the root cause of that problem?

We are focusing on the composer again when the attachment menu item is selected.

What changes do you think we should make in order to solve the problem?

Do same thing like this PR for emoji suggestion

What alternative solutions did you explore? (Optional)

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~016704c5d525d79faa

[melvin-bot]

Current assignee @anmurali is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @0xmiroslav (External)