[$1000] Currency in Submit button in final confirmation page has lower case letter

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. open a chat
2. click + button
3. click Request money
4. Choose a currency that does not have dedicated symbol e.g. SGD
5. Enter 100 as amount and click next

Expected Result:

Green submit button should have text “Request SGD 100.00”

Actual Result:

Green submit button displaying text “Request Sgd 100.00", inconsistent lettercase compared to Amount field

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.13.1
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Screen.Recording.2023-05-11.at.6.22.42.PM.mov

Expensify/Expensify Issue URL:
Issue reported by: @honnamkuan
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1683800647653469

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01750cd430f4708452
• Upwork Job ID: 1658422921107083264
• Last Price Increase: 2023-05-16

[melvin-bot]

Triggered auto assignment to @JmillsExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[allroundexperts]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The currency text is displayed incorrectly.

What is the root cause of that problem?

We're re-recapitalizing the text here.

What changes do you think we should make in order to solve the problem?

We should remove the Str.recapitalize function here. Probably, we also should change the translations for split and request such that they start with upper case here.

What alternative solutions did you explore? (Optional)

None

[payal-lathidadiya]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Currency text in Submit button in confirmation page has lower case letter

What is the root cause of that problem?

We are converting text copy here which will convert it to title case.

What changes do you think we should make in order to solve the problem?

We have to modify logic here and create new function which will convert first letter to whole input to Capital instead of each word in string.

So, request SGD 100 will become as splitAmount Request SGD 100

What alternative solutions did you explore? (Optional)

None

[melvin-bot]

📣 @payal-lathidadiya! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

1. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
2. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
3. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
   
   Format:

Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

[payal-lathidadiya]

Contributor details
Your Expensify account email: payal.lathidadiya@gmail.com
Upwork Profile Link: https://www.upwork.com/freelancers/~01961fe1f0c2d39e9b

[melvin-bot]

✅ Contributor details stored successfully. Thank you for contributing to Expensify!

[Pujan92]

Seems regression from #18143 (166d5d6)
cc @Julesssss

[Julesssss]

Ah right. We removed capitalisation for the messages but should have added it specifically to the currency.

[dukenv0307]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Currency in Submit button in final confirmation page has lower case letter

What is the root cause of that problem?

App/src/components/MoneyRequestConfirmationList.js

Lines 110 to 114 in 2376b77

	text: Str.recapitalize(
	this.props.translate(this.props.hasMultipleParticipants ? 'iou.splitAmount' : 'iou.requestAmount', {
	amount: CurrencyUtils.convertToDisplayString(this.props.iouAmount, this.props.iou.selectedCurrencyCode),
	}),
	),

We are modifying the string so the first letter of each word is capitalized and the rest lowercased.

What changes do you think we should make in order to solve the problem?

we only should modify the first letter of the string to be capitalized. So we can use UCFirst function instead of recapitalize function

What alternative solutions did you explore? (Optional)