[HOLD for payment 2023-05-25] [$1000] Auto-suggester throws console error when scrolling through less than 5 options

[puneetlath]

If you only have one option and you use the arrow keys to scroll through the list, you see a console error. We should fix this.

bug0.mov

@0xmiroslav did you want to take this one?

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01d83c4180a356aaa0
• Upwork Job ID: 1656674431586570240
• Last Price Increase: 2023-05-11

[melvin-bot]

Triggered auto assignment to @abekkala (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[allroundexperts]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Auto suggester throws console error when selecting an option through keyboard

What is the root cause of that problem?

The root cause is that we're calculating an incorrect getMaxArrowIndex here.

This error occurs on emoji selection as well because we're using the same function there as well.

What changes do you think we should make in order to solve the problem?

We need to change the getMaxArrowIndex function to:

const getMaxArrowIndex = (numRows, isAutoSuggestionPickerLarge) => {
    const maxToUse = isAutoSuggestionPickerLarge ? CONST.AUTO_COMPLETE_SUGGESTER.MAX_AMOUNT_OF_ITEMS : CONST.AUTO_COMPLETE_SUGGESTER.MIN_AMOUNT_OF_ITEMS;
    if (numRows > maxToUse) {
        return maxToUse - 1;
    }

    return numRows - 1;
};

What alternative solutions did you explore? (Optional)

None

@puneetlath I'm not expecting to get paid here. Feel free to assign this to @0xmiroslav if he wants to take this over. It's really late here and I can't seem to sleep so just trying to help.

[0xmiroslav]

@0xmiroslav did you want to take this one?

@puneetlath yes I'd like to

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01d83c4180a356aaa0

[melvin-bot]

Current assignees @puneetlath and @abekkala are eligible for the External assigner, not assigning anyone new.